refactor: set storage object on KV store open #2837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpoletaev
added
the
t-core-services
github-actions
bot
added
the
tested
B4nan
approved these changes
Feb 10, 2025
Member
B4nan
left a comment
B4nan
left a comment
There was a problem hiding this comment.
looking good, i am just wondering if we should make this a refactor, i don't see much value in keeping this in the changelog
danpoletaev
changed the title
This was referenced Feb 17, 2025
danpoletaev
added a commit
to apify/crawlee-python
that referenced
this pull request
Mar 4, 2025
### Description Currently, when opening a KV store, dataset or request queue we only store the id and name from the get() response. This PR updates the logic to store the entire storage_object, allowing access to additional attributes without requiring extra requests. More context in [slack](https://apify.slack.com/archives/CD0SF6KD4/p1738936334553189) P.S. Python Crawlee storage constructors are a bit different than JS storage consturctors, that's why I've added storage_object to all of the classes - KV store, dataset & request queue [Similar PR in Crawlee JS](apify/crawlee#2837) ### Testing I've added one test, which checks that KV store class has storage_object after open.
fnesveda
added
the
validated
danpoletaev
added a commit
that referenced
this pull request
Aug 5, 2025
Following up on [this recent update](#2837) where we started storing the full storageObject when opening a key-value store, this PR applies the same logic when opening a dataset. This change prepares the ground for adding a new method: Dataset.createItemsPublicUrl, which will need access to the dataset's urlSigningSecretKey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when opening a KV store, we only store the id and name from the get() response.
This PR updates the logic to store the entire storageObject, allowing access to additional attributes without requiring extra requests.
More context in slack