refactor!: Rename PwPreNavContext to PwPreNavCrawlingContext

[vdusek]

Description

• Rename PlaywrightPreNavigationContext to PlaywrightPreNavigationCrawlingContext.
• Of course, this is really long. Do we want to make it shorter, e.g.: PlaywrightPreNavCrawlingContext?
• Or make shorter all the crawling contexts... e.g. use just CrawlContext, (PlaywrightPreNavCrawlContext)
• Opinions?

Breaking changes

• The PlaywrightPreNavigationContext was renamed to PlaywrightPreNavCrawlingContext.

[janbuchar]

I'm not sure if the consistency is worth the BC break. Also, yes, the new name does seem long, and inventing new abbreviations such as CrawlContext doesn't make much sense to me. That's my opinion, feel free to try and change it 😄

[vdusek]

@janbuchar And what about PlaywrightPreNavCrawlingContext? At least a few chars shorter. The issue is that all other "crawling contexts" are consistently named as CrawlingContext, except for this one. Additionally, the term "context" is used for other purposes, such as launch context, browser context, ...

[janbuchar]

Is it even crawling if you haven't navigated to the page yet? 🙂 We do have a lot of contexts, but this one doesn't fit with crawling context all that well either...

[vdusek]

True, but the same applies to the basic crawling context 🙂. This was just an idea to straighten things out for now. The PwPreNavCC was written by an external developer, and we (or at least I) overlooked the absence of "crawling" in it.

[Pijukatel]

I agree it should be consistently named. I am split on using abbreviations, I like to make the name shorter, but on the other hand "Explicit is better than implicit".

If the developer will have to constantly look what some abbreviation means, then it is bad. If on the other hand it is natural and people understand it out of the box, then I think it is OK.

PwPreNavCC? Why not if the docstring starts as """PlaywrightPreNavigationCrawlingContext is ...." Even though I would maybe keep at least one full key word in the name to roughly recognize the type on the first glance. For example: PwPreNavCContext

[vdusek]

Agreed. But for this PR and the v0.5 release, let's focus only on resolving the PlaywrightPreNavCrawlingContext issue. The broader discussion about simplifying these names (...CrawlContext, ...CContext, ...Context, etc.) should be postponed for later, it will be more difficult and we will also have to discuss that with JS-guys, as this naming should be aligned.

[janbuchar]

Still not sure about the benefit of the change, but I won't block it 😁