refactor!: remove json_ and order_no from Request
#788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mantisus
changed the title
json_ and order_no from Request
Mantisus
changed the title
json_ and order_no from Requestjson_ and order_no from Request
janbuchar
reviewed
Dec 6, 2024
Mantisus
added
t-tooling
vdusek
requested changes
Dec 11, 2024
Mantisus
changed the title
json_ and order_no from Requestjson_ and order_no from Request
janbuchar
reviewed
Dec 13, 2024
janbuchar
reviewed
Dec 13, 2024
|
|
||
| payload: Annotated[ | ||
| HttpPayload | None, | ||
| BeforeValidator(lambda v: v.encode() if isinstance(v, str) else v), |
Collaborator
There was a problem hiding this comment.
Isn't the BeforeValidator still needed when loading an old request file?
Collaborator
Author
There was a problem hiding this comment.
Good point. We need both so that payload is correctly serialized and deserialized to a file.
Updated the e2e test.
janbuchar
reviewed
Dec 13, 2024
Co-authored-by: Jan Buchar <[email protected]>
vdusek
modified the milestones:
104th sprint - Tooling team,
105th sprint - Tooling team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
json_andorder_nofromRequestwhich is a model of external API. Creating an internal modelInternalRequestto work inside_request_queue_clientIssues
json_andorder_nofromRequest#94Checklist