-
Notifications
You must be signed in to change notification settings - Fork 514
fix: Fix serialization payload in Request. Fix Docs for Post Request #683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
531271e
fix serialization payload, docs fix
Mantisus 98cabb0
update test for payload serialization
Mantisus cb6b013
move validation and serialization to Annotated field
Mantisus 6d52d42
small code optimization in docs
Mantisus 40ad62f
add more payload tests
Mantisus 6fa2ae0
Update tests/unit/_memory_storage_client/test_request_queue_client.py
Mantisus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -93,19 +93,20 @@ async def test_list_head(request_queue_client: RequestQueueClient) -> None: | |
|
|
||
|
|
||
| async def test_request_state_serialization(request_queue_client: RequestQueueClient) -> None: | ||
| request = Request.from_url('https://crawlee.dev') | ||
| request = Request.from_url('https://crawlee.dev', payload=b'test') | ||
| request.state = RequestState.UNPROCESSED | ||
|
|
||
| await request_queue_client.add_request(request) | ||
|
|
||
| result = await request_queue_client.list_head() | ||
|
|
||
| assert len(result.items) == 1 | ||
| assert result.items[0] == request | ||
|
|
||
| got_request = await request_queue_client.get_request(request.id) | ||
|
|
||
| assert request == got_request | ||
| assert request.payload == got_request.payload | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This comparison is part of |
||
| assert got_request.payload != b"b'test'" | ||
Mantisus marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
|
|
||
| async def test_add_record(request_queue_client: RequestQueueClient) -> None: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is scary - could you return
vin theelsebranch instead?