Skip to content

feat: Add BeautifulSoupParser type alias #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2024
Merged

feat: Add BeautifulSoupParser type alias #674

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c28b49
Add BeautifoulSoupParser for typing.
Pijukatel Nov 10, 2024
f528a5b
Update __init__.py
Pijukatel Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/crawlee/beautifulsoup_crawler/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
try:
from ._beautifulsoup_crawler import BeautifulSoupCrawler
from ._beautifulsoup_crawler import BeautifulSoupCrawler, BeautifulSoupParser
from ._beautifulsoup_crawling_context import BeautifulSoupCrawlingContext
except ImportError as exc:
raise ImportError(
Expand Down
4 changes: 3 additions & 1 deletion src/crawlee/beautifulsoup_crawler/_beautifulsoup_crawler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
if TYPE_CHECKING:
from crawlee._types import BasicCrawlingContext, EnqueueLinksKwargs

BeautifulSoupParser = Literal['html.parser', 'lxml', 'xml', 'html5lib']


class BeautifulSoupCrawler(BasicCrawler[BeautifulSoupCrawlingContext]):
"""A web crawler for performing HTTP requests and parsing HTML/XML content.
Expand Down Expand Up @@ -61,7 +63,7 @@ async def request_handler(context: BeautifulSoupCrawlingContext) -> None:
def __init__(
self,
*,
parser: Literal['html.parser', 'lxml', 'xml', 'html5lib'] = 'lxml',
parser: BeautifulSoupParser = 'lxml',
additional_http_error_status_codes: Iterable[int] = (),
ignore_http_error_status_codes: Iterable[int] = (),
**kwargs: Unpack[BasicCrawlerOptions[BeautifulSoupCrawlingContext]],
Expand Down
Loading