Skip to content

chore!: Remove Request.query_params field #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2024
Merged

chore!: Remove Request.query_params field #639

merged 2 commits into from
Nov 1, 2024

Conversation

@vdusek
Copy link
Collaborator

@vdusek vdusek commented Oct 31, 2024 •
edited
Loading

Description

  • Remove Request.query_params field.
  • The URL params can be sent as a part of the URL and both our HTTP clients can handle it.

Issues

Testing

  • Add a new test checking the URL query params.

Checklist

  • CI passed

@vdusek vdusek requested a review from janbuchar October 31, 2024 15:51
@github-actions github-actions bot added this to the 101st sprint - Tooling team milestone Oct 31, 2024
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Oct 31, 2024
github-actions[bot]
github-actions bot reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

None of the pull request and linked issue has estimate

@vdusek vdusek changed the title chore!: rm Request.query_params field chore!: Remove Request.query_params field Oct 31, 2024
janbuchar
janbuchar approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek vdusek merged commit 6ec0ec4 into master Nov 1, 2024
21 checks passed
@vdusek vdusek deleted the rm-query-params branch November 1, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@janbuchar janbuchar janbuchar approved these changes

Assignees

@vdusek vdusek

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Milestone

101st sprint - Tooling team

Development

Successfully merging this pull request may close these issues.

What to do with the request query params field?

3 participants

@vdusek @janbuchar