feat: Pass extra configuration to json.dump() #622
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR is based on all the discussions in the parent issue and the suggestions thereafter. Please review and suggest changes, if any. Thank you. cc: @vdusek @janbuchar |
vdusek
requested changes
Oct 29, 2024
Collaborator
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
Make sure the CI passes, see the CONTRIBUTING.md for more information.
janbuchar
requested changes
Oct 31, 2024
Collaborator
janbuchar
left a comment
janbuchar
left a comment
There was a problem hiding this comment.
The CI is still failing, can you please fix the issues?
Contributor
Author
|
@janbuchar I will push a commit to fix some of them by EOD. |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the need for customizable export configurations when using the await crawler.export_data("export.json") method.
Key Changes:
json.dump()and other export functions.BasicCrawler, includingexport_data_jsonandexport_data_csv. This separation enhances clarity and maintainability while providing format-specific options.This enhancement improves the flexibility of data exports, enabling users to tailor their export settings to meet specific requirements.
Issues
Fixes #526
Testing
Unit test cases are added to check the updated configuration and functionality.
Checklist