Skip to content

ci: use python version instead of executable path #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2024
Merged

ci: use python version instead of executable path #582

merged 3 commits into from
Oct 8, 2024

Conversation

@vdusek
Copy link
Collaborator

@vdusek vdusek commented Oct 8, 2024

image

@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. infrastructure Issues related to infrastructure or CI/CD pipeline. labels Oct 8, 2024
@vdusek vdusek added this to the 100th sprint - Tooling team milestone Oct 8, 2024
@vdusek vdusek requested a review from janbuchar October 8, 2024 12:33
@vdusek vdusek self-assigned this Oct 8, 2024
@janbuchar
Copy link
Collaborator

janbuchar commented Oct 8, 2024 •
edited
Loading

Is this actually needed? The github actions runners are guaranteed (https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2004-Readme.md) to have at least some version of python installled, and that sounds good enough for this workflow.

@vdusek vdusek changed the title ci: add missing setup-python step ci: add missing setup-python step and use python-version instead of executable path Oct 8, 2024
@vdusek vdusek changed the title ci: add missing setup-python step and use python-version instead of executable path ci: use python-version instead of executable path Oct 8, 2024
@vdusek vdusek changed the title ci: use python-version instead of executable path ci: use python version instead of executable path Oct 8, 2024
@vdusek vdusek merged commit 8fa2b4b into master Oct 8, 2024
14 of 22 checks passed
@vdusek vdusek deleted the add-missing-setup-python-step branch October 8, 2024 13:42
deshansh pushed a commit to deshansh/crawlee-python that referenced this pull request Oct 19, 2024
@vdusek @deshansh
ci: use python version instead of executable path (apify#582)
fc0d1b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janbuchar janbuchar janbuchar approved these changes

Assignees

@vdusek vdusek

Labels

adhoc Ad-hoc unplanned task added during the sprint. infrastructure Issues related to infrastructure or CI/CD pipeline. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Milestone

100th sprint - Tooling team

Development

Successfully merging this pull request may close these issues.

3 participants

@vdusek @janbuchar