refactor!: Remove Request.id field
#1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-tooling
vdusek
requested changes
Aug 20, 2025
vdusek
requested changes
Aug 20, 2025
Co-authored-by: Vlada Dusek <[email protected]>
vdusek
requested changes
Aug 20, 2025
Co-authored-by: Vlada Dusek <[email protected]>
vdusek
changed the title
request.idRequest.id field
janbuchar
approved these changes
Aug 21, 2025
|
|
||
| id: Annotated[str, Field(alias='requestId')] | ||
| id: Annotated[str | None, Field(alias='requestId', default=None)] = None | ||
| """Represents internal representation of the request by the storage client. Only some clients use id.""" |
There was a problem hiding this comment.
It represents a representation? You probably want to reword this 🙂
Pijukatel
added a commit
to apify/apify-sdk-python
that referenced
this pull request
Aug 22, 2025
### Description - Remove `request.id` and replace all usages of `id` with `unique_key` - Add transformation from `unique_key` to `id` and use it when calling id-based client methods - Requires: - apify/crawlee-python#1366 ### Issues - Part of: apify/crawlee-python#1358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues
request.id#1358Testing
Benchmarking actor was created and run based on these branches.