refactor!: Change method HttpResponse.read from sync to async
#1296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mantisus
changed the title
read for Response from sync to asyncread for Response from sync to async
vdusek
requested changes
Jul 9, 2025
Collaborator
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
That makes sense, thanks, just please describe it in the upgrading guide 🙂.
Mantisus
changed the title
read for Response from sync to asyncread for HttpResponse from sync to async
vdusek
changed the title
read for HttpResponse from sync to asyncHttpResponse.read from sync to async
vdusek
added
t-tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
readmethod forHttpResponseasynchronous. This is more consistent in a fully asynchronous framework. More flexible than a synchronous method