Skip to content

fix: Do not raise an error to check 'same-domain' if there is no hostname in the url #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2025
Merged

fix: Do not raise an error to check 'same-domain' if there is no hostname in the url #1251

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36edee6
don`t raise error from check _check_enqueue_strategy
Mantisus Jun 16, 2025
b06444f
update _check_enqueue_strategy
Mantisus Jun 16, 2025
1d9b282
add warning message
Mantisus Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/crawlee/crawlers/_basic/_basic_crawler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -967,7 +967,7 @@ def _check_enqueue_strategy(

if strategy == 'same-domain':
if origin_url.hostname is None or target_url.hostname is None:
raise ValueError('Both origin and target URLs must have a hostname')
return False

origin_domain = self._tld_extractor.extract_str(origin_url.hostname).domain
target_domain = self._tld_extractor.extract_str(target_url.hostname).domain
Expand Down
Loading