Skip to content

fix: improve extension of Configuration class to fix issues in native ESM projects #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
B4nan merged 1 commit into from
May 19, 2025
Merged

fix: improve extension of Configuration class to fix issues in native ESM projects #394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/apify/src/configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export class Configuration extends CoreConfiguration {
// maps environment variables to config keys (e.g. `APIFY_MEMORY_MBYTES` to `memoryMbytes`)
protected static override ENV_MAP = {
// regular crawlee env vars are also supported
...super.ENV_MAP,
...CoreConfiguration.ENV_MAP,

// support crawlee env vars prefixed with `APIFY_` too
APIFY_AVAILABLE_MEMORY_RATIO: 'availableMemoryRatio',
Expand Down Expand Up @@ -180,22 +180,22 @@ export class Configuration extends CoreConfiguration {
};

protected static override INTEGER_VARS = [
...super.INTEGER_VARS,
...CoreConfiguration.INTEGER_VARS,
'proxyPort',
'containerPort',
'metamorphAfterSleepMillis',
'maxTotalChargeUsd',
];

protected static override BOOLEAN_VARS = [
...super.BOOLEAN_VARS,
...CoreConfiguration.BOOLEAN_VARS,
'isAtHome',
'testPayPerEvent',
'useChargingLogDataset',
];

protected static override DEFAULTS = {
...super.DEFAULTS,
...CoreConfiguration.DEFAULTS,
defaultKeyValueStoreId:
LOCAL_ACTOR_ENV_VARS[ACTOR_ENV_VARS.DEFAULT_KEY_VALUE_STORE_ID],
defaultDatasetId:
Expand Down
Loading