Skip to content

fix: respect KVS.getPublicUrl() from core when not on apify platform #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
B4nan merged 1 commit into from
May 29, 2024
Merged

fix: respect KVS.getPublicUrl() from core when not on apify platform #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/apify/src/key_value_store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
import type { StorageManagerOptions } from '@crawlee/core';
import { KeyValueStore as CoreKeyValueStore } from '@crawlee/core';

import type { Configuration } from './configuration';

// @ts-ignore newer crawlee versions already declare this method in core
const { getPublicUrl } = CoreKeyValueStore.prototype;

/**
* @inheritDoc
*/
Expand All @@ -10,6 +15,10 @@ export class KeyValueStore extends CoreKeyValueStore {
* access the value in the remote key-value store.
*/
getPublicUrl(key: string): string {
if (!(this.config as Configuration).get('isAtHome') && getPublicUrl) {
return getPublicUrl.call(this, key);
}

return `https://api.apify.com/v2/key-value-stores/${this.id}/records/${key}`;
}

Expand All @@ -21,5 +30,5 @@ export class KeyValueStore extends CoreKeyValueStore {
}
}

// @ts-expect-error extension of the core class to make this only a type-issue
// @ts-ignore newer crawlee versions already declare this method in core
CoreKeyValueStore.prototype.getPublicUrl = KeyValueStore.prototype.getPublicUrl;