Skip to content

Conversation

@valekjo
Copy link
Member

@valekjo valekjo commented Jul 2, 2025

The field is returned from the API, but the type was missing it.

In case of TEST event, it's null.

@valekjo valekjo requested review from katacek and vladfrangu July 2, 2025 07:27
@valekjo valekjo added adhoc Ad-hoc unplanned task added during the sprint. t-console Issues with this label are in the ownership of the console team. labels Jul 2, 2025
@github-actions github-actions bot added this to the 118th sprint - Console team milestone Jul 2, 2025
Copy link
Member

@katacek katacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! 🚀

responseBody: string | null;
}

export type WebhookDispatchEventData = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use an interface instead of an object type. interfaces will have their own page in API docs, types are only rendered as part of the package index.

@valekjo valekjo merged commit 351f11f into master Jul 2, 2025
7 checks passed
@valekjo valekjo deleted the fix/improved-webhook-dispatch-types branch July 2, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-console Issues with this label are in the ownership of the console team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants