Skip to content

feat: added data property to API error object#559

Merged
gippy merged 3 commits into
masterfrom
feature/added-data-to-error
Jun 26, 2024
Merged

feat: added data property to API error object#559
gippy merged 3 commits into
masterfrom
feature/added-data-to-error

Conversation

@gippy

@gippy gippy commented Jun 18, 2024

Copy link
Copy Markdown
Member

This update is needed because in API we will be adding a new data field to the API error, which will be used during dataset validation.

apify/apify-docs#1079

@gippy gippy self-assigned this Jun 18, 2024
@gippy gippy requested review from barjin and janbuchar June 18, 2024 13:40
@gippy gippy added adhoc Ad-hoc unplanned task added during the sprint. product roadmap Issues synchronized to product roadmap. t-console Issues with this label are in the ownership of the console team. labels Jun 18, 2024
@github-actions github-actions Bot added this to the 92nd sprint - Console team milestone Jun 18, 2024
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label Jun 18, 2024
github-actions[bot]

This comment was marked as resolved.

Comment thread test/apify_api_error.test.js Outdated

@barjin barjin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the test-related nit above, it seems pretty harmless to me 👍🏽

@gippy gippy removed the request for review from janbuchar June 25, 2024 10:49
@gippy gippy merged commit 3b7c4b7 into master Jun 26, 2024
@gippy gippy deleted the feature/added-data-to-error branch June 26, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. product roadmap Issues synchronized to product roadmap. t-console Issues with this label are in the ownership of the console team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants