Skip to content

Fixed test coverage report failing to generate on Windows #4544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2024
Merged

Fixed test coverage report failing to generate on Windows #4544

merged 1 commit into from
Jun 26, 2024

Conversation

@Sebastian-Webster
Copy link
Contributor

@Sebastian-Webster Sebastian-Webster commented Jun 26, 2024

This PR fixes the test coverage report failing to generate on Windows by running nyc in a shell if the command is ran from a Windows machine.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@junedchhipa junedchhipa merged commit 14f6e28 into apexcharts:main Jun 26, 2024
@samul-1 samul-1 mentioned this pull request Jul 27, 2024
Open
@engbaher77 engbaher77 mentioned this pull request Jul 27, 2024
Open
@Sheitak Sheitak mentioned this pull request Jul 27, 2024
Open
@bikramtuladharyipl bikramtuladharyipl mentioned this pull request Jul 27, 2024
Merged
This was referenced Jul 28, 2024
Open
Open
@Pyloris Pyloris mentioned this pull request Jul 31, 2024
Merged
@MGomaa10 MGomaa10 mentioned this pull request Jul 31, 2024
Open
@Sheitak Sheitak mentioned this pull request Jul 31, 2024
Open
@stevenalp207 stevenalp207 mentioned this pull request Aug 1, 2024
Open
This was referenced Aug 1, 2024
Open
Open
Open
Open
Open
Open
Open
@Sheitak Sheitak mentioned this pull request Aug 8, 2024
Open
@sgkens sgkens mentioned this pull request Aug 9, 2024
Merged
This was referenced Aug 10, 2024
Open
Open
@samul-1 samul-1 mentioned this pull request Aug 12, 2024
Open
@engbaher77 engbaher77 mentioned this pull request Aug 12, 2024
Open
@Sheitak Sheitak mentioned this pull request Aug 12, 2024
Open
@sgkens sgkens mentioned this pull request Aug 12, 2024
Open
This was referenced Aug 13, 2024
Open
Open
This was referenced Sep 25, 2024
Open
Open
Open
@sandaru-madhubhashana sandaru-madhubhashana mentioned this pull request Sep 27, 2024
Open
@Sheitak Sheitak mentioned this pull request Sep 28, 2024
Open
@CharlesGuerrero14 CharlesGuerrero14 mentioned this pull request Sep 29, 2024
Open
@Sheitak Sheitak mentioned this pull request Sep 29, 2024
Open
@YuvrajKaushal YuvrajKaushal mentioned this pull request Sep 30, 2024
Open
This was referenced Sep 30, 2024
Open
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 1, 2024
Open
@l0renz02017 l0renz02017 mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 2, 2024
Open
Open
Open
Open
Open
@Wiran-Larbi Wiran-Larbi mentioned this pull request Oct 25, 2024
Open
@engbaher77 engbaher77 mentioned this pull request Oct 25, 2024
Open
@Sheitak Sheitak mentioned this pull request Oct 26, 2024
Open
@samul-1 samul-1 mentioned this pull request Oct 31, 2024
Open
@PaolaQ-I PaolaQ-I mentioned this pull request Nov 1, 2024
Open
@mflorezmejia mflorezmejia mentioned this pull request Nov 1, 2024
Open
@CharlesGuerrero14 CharlesGuerrero14 mentioned this pull request Nov 2, 2024
Open
@Sheitak Sheitak mentioned this pull request Nov 2, 2024
Open
@deployor deployor mentioned this pull request Nov 4, 2024
Open
@samul-1 samul-1 mentioned this pull request Nov 7, 2024
Open
@Wiran-Larbi Wiran-Larbi mentioned this pull request Nov 8, 2024
Open
@engbaher77 engbaher77 mentioned this pull request Nov 8, 2024
Open
@Sheitak Sheitak mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junedchhipa junedchhipa junedchhipa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sebastian-Webster @junedchhipa