Skip to content

Return all columns in TsBlock class #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JackieTien97 merged 3 commits into from
May 17, 2024
Merged

Return all columns in TsBlock class #80

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff8d248
Return all columns in TsBlock class.
Sh-Zh-7 May 17, 2024
57fb4a0
Add javadoc for new method.
Sh-Zh-7 May 17, 2024
7fa6d54
Format with `mvn spotless:apply -P with-java`.
Sh-Zh-7 May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions java/tsfile/src/main/java/org/apache/tsfile/read/common/block/TsBlock.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,17 @@ public Column[] getColumns(int[] columnIndexes) {
return columns;
}

/**
* Collected all columns into a column array. Note that the timestamps are at the last column.
*
* @return column array composed of all columns.
*/
public Column[] getAllColumns() {
Copy link
Contributor

@JackieTien97 JackieTien97 May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add java doc for this method, specially for its return value

Copy link
Contributor Author

@Sh-Zh-7 Sh-Zh-7 May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Column[] columns = Arrays.copyOf(valueColumns, valueColumns.length + 1);
columns[valueColumns.length] = timeColumn;
return columns;
}

public TsBlockSingleColumnIterator getTsBlockSingleColumnIterator() {
return new TsBlockSingleColumnIterator(0);
}
Expand Down