Skip to content

Check max tsfile version #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JackieTien97 merged 2 commits into from
Jul 21, 2025
Merged

Check max tsfile version #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d22af93
check max version
shuwenwei Jul 21, 2025
f0fe2bc
fix ut
shuwenwei Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions java/tsfile/src/main/java/org/apache/tsfile/exception/read/FileVersionTooOldException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@

public class FileVersionTooOldException extends IOException {

public FileVersionTooOldException(byte currentVersion, byte minimumVersion) {
public FileVersionTooOldException(byte currentVersion, byte minimumVersion, byte maximumVersion) {
super(
String.format(
"The current version %d is too old, please at least upgrade to %d",
currentVersion, minimumVersion));
"The current version %d is not supported. Currently supported versions are %d to %d.",
currentVersion, minimumVersion, maximumVersion));
}
}
5 changes: 3 additions & 2 deletions java/tsfile/src/main/java/org/apache/tsfile/read/TsFileSequenceReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,9 @@ private void configDeserializer() {
}

private void checkFileVersion() throws FileVersionTooOldException {
if (TSFileConfig.VERSION_NUMBER - fileVersion > 1) {
throw new FileVersionTooOldException(fileVersion, (byte) (TSFileConfig.VERSION_NUMBER - 1));
if (fileVersion < TSFileConfig.VERSION_NUMBER_V3 || fileVersion > TSFileConfig.VERSION_NUMBER) {
throw new FileVersionTooOldException(
fileVersion, TSFileConfig.VERSION_NUMBER_V3, TSFileConfig.VERSION_NUMBER);
}
}

Expand Down
6 changes: 5 additions & 1 deletion java/tsfile/src/test/java/org/apache/tsfile/utils/TsFileUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

import org.apache.tsfile.common.conf.TSFileConfig;
import org.apache.tsfile.constant.TestConstant;
import org.apache.tsfile.read.TsFileSequenceReader;
import org.apache.tsfile.write.writer.LocalTsFileOutput;
import org.apache.tsfile.write.writer.TsFileIOWriter;

Expand Down Expand Up @@ -67,6 +68,9 @@ public void after() {
@Test
public void isTsFileCompleteTest() throws IOException {
Assert.assertTrue(TsFileUtils.isTsFileComplete(new File(COMPLETE_FILE_PATH)));
Assert.assertFalse(TsFileUtils.isTsFileComplete(new File(INCOMPLETE_FILE_PATH)));
try (TsFileSequenceReader reader = new TsFileSequenceReader(INCOMPLETE_FILE_PATH)) {
Assert.fail();
} catch (Exception ignored) {
}
}
}
Loading