Add TsFileLastReader for retrieving last points in a TsFile #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #498 +/- ##
===========================================
+ Coverage 65.71% 65.78% +0.06%
===========================================
Files 565 566 +1
Lines 33062 33291 +229
Branches 4611 4651 +40
===========================================
+ Hits 21728 21899 +171
- Misses 10684 10742 +58
Partials 650 650 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shuwenwei
approved these changes
May 21, 2025
shuwenwei
reviewed
May 21, 2025
| return new MeasurementSchema(measurementUid, tsDataType, encoding, compressionType); | ||
| } | ||
|
|
||
| public TSEncoding getEncoding() { |
Member
There was a problem hiding this comment.
This method is not used and it may lead to the wrong way of using it
shuwenwei
reviewed
May 21, 2025
| TsPrimitiveType.getByType(seriesMeta.getTsDataType(), | ||
| seriesMeta.getStatistics().getLastValue()))); | ||
| } else { | ||
| ChunkMetadata chunkMetadata = (ChunkMetadata) seriesMeta.getChunkMetadataList() |
Member
There was a problem hiding this comment.
The last chunk could be an empty chunk
(cherry picked from commit 40105d1)
shuwenwei
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title declares