Remove redundant conversion in TableResultSet #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes a redundant conversion in TableResultSet to improve performance when reading TsFiles.
- Refactors TableResultSet to directly access block data instead of converting through TimeValuePair.
- Adds explicit accessor methods for various data types (int, long, double, float, boolean, date, binary, string).
- Updates BinaryColumn isNull to include a direct null check on the values array.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| java/tsfile/src/main/java/org/apache/tsfile/read/query/dataset/TableResultSet.java | Optimizes data retrieval by removing redundant conversion logic. |
| java/tsfile/src/main/java/org/apache/tsfile/read/common/block/column/BinaryColumn.java | Modifies the isNull method to also check null status of the values array. |
java/tsfile/src/main/java/org/apache/tsfile/read/common/block/column/BinaryColumn.java
Outdated
Show resolved
Hide resolved
…column/BinaryColumn.java Co-authored-by: Copilot <[email protected]>
HTHou
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time consumption of reading a TsFile of 120MB with all floats:
5.3s -> 3.5s