Skip to content

Fix getValue method in Tablet doesn't support Date and Timestamp type #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jt2594838 merged 2 commits into from
Sep 20, 2024
Merged

Fix getValue method in Tablet doesn't support Date and Timestamp type #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8628d9
Fix getValue method in Tablet doesn't support Date and Timestamp type
HTHou Sep 19, 2024
b73be04
add UT
HTHou Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions java/tsfile/src/main/java/org/apache/tsfile/write/record/Tablet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,7 +946,10 @@ public Object getValue(int i, int j) {
case BOOLEAN:
return ((boolean[]) values[j])[i];
case INT64:
case TIMESTAMP:
return ((long[]) values[j])[i];
case DATE:
return ((LocalDate[]) values[j])[i];
default:
throw new IllegalArgumentException("Unsupported type: " + schemas.get(j).getType());
}
Expand Down
14 changes: 12 additions & 2 deletions java/tsfile/src/test/java/org/apache/tsfile/write/record/TabletTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,12 @@ public void testSerializationAndDeSerialization() {
try {
final ByteBuffer byteBuffer = tablet.serialize();
final Tablet newTablet = Tablet.deserialize(byteBuffer);
assertEquals(newTablet, tablet);
assertEquals(tablet, newTablet);
for (int i = 0; i < rowSize; i++) {
for (int j = 0; j < tablet.getSchemas().size(); j++) {
assertEquals(tablet.getValue(i, j), newTablet.getValue(i, j));
}
}
} catch (final Exception e) {
e.printStackTrace();
fail();
Expand Down Expand Up @@ -132,7 +137,12 @@ public void testSerializationAndDeSerializationWithMoreData() {
try {
final ByteBuffer byteBuffer = tablet.serialize();
final Tablet newTablet = Tablet.deserialize(byteBuffer);
assertEquals(newTablet, tablet);
assertEquals(tablet, newTablet);
for (int i = 0; i < rowSize; i++) {
for (int j = 0; j < tablet.getSchemas().size(); j++) {
assertEquals(tablet.getValue(i, j), newTablet.getValue(i, j));
}
}
} catch (final Exception e) {
e.printStackTrace();
fail();
Expand Down