Fix flaky TraversalExplanationTest #3259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsalExplanationTest.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.8-dev #3259 +/- ##
==========================================
Coverage ? 77.30%
Complexity ? 15013
==========================================
Files ? 1159
Lines ? 71922
Branches ? 8023
==========================================
Hits ? 55599
Misses ? 13273
Partials ? 3050 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kenhuuu
reviewed
Oct 30, 2025
.../test/java/org/apache/tinkerpop/gremlin/process/traversal/util/TraversalExplanationTest.java
Outdated
Show resolved
Hide resolved
Contributor
|
VOTE +1 |
…riplet parts instead of using the unreliable prettyPrint output which can add line breaks in the middle of strategy and step names.
Contributor
Author
|
Note that I had originally changed the test to add troubleshooting output but after the build failed for this PR I was able to determine the cause of the flakiness was the usage of |
andreachild
changed the title
Contributor
|
VOTE+1 again after update to fix test |
Contributor
|
VOTE +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored flaky test
TraversalExplanationTest.shouldApplyStrategiesCorrectlywhich has started failing more often when executed by github actions. This changeset changes the test to validate the individual parts of theTraversalExplanationtriplets (strategy name, strategy category, steps) instead of using theprettyPrintoutput which can add line breaks in the middle of strategy and step names.VOTE +1