TEZ-4506: Report the node of a task attempt failure better.

[ayushtkn]

No description provided.

[tez-yetus]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	16m 2s	master passed
+1 💚	compile	0m 28s	master passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu122.04
+1 💚	compile	0m 26s	master passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
+1 💚	checkstyle	1m 16s	master passed
+1 💚	javadoc	0m 34s	master passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu122.04
+1 💚	javadoc	0m 19s	master passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
+0 🆗	spotbugs	1m 15s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 17s	the patch passed
+1 💚	compile	0m 17s	the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu122.04
+1 💚	javac	0m 17s	the patch passed
+1 💚	compile	0m 15s	the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
+1 💚	javac	0m 15s	the patch passed
+1 💚	checkstyle	0m 9s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 8s	the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu122.04
+1 💚	javadoc	0m 8s	the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
+1 💚	findbugs	0m 40s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 45s	tez-runtime-internals in the patch passed.
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		24m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-307/1/artifact/out/Dockerfile
GITHUB PR	#307
JIRA Issue	TEZ-4506
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname	Linux a171edab3c85 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/tez.sh
git revision	master / b643f9b
Default Java	Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-307/1/testReport/
Max. process+thread count	92 (vs. ulimit of 5500)
modules	C: tez-runtime-internals U: tez-runtime-internals
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-307/1/console
versions	git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[abstractdog]

thanks for the patch @ayushtkn, basically, it looks good to me
can you paste here how you tested this and what was the diagnostic message like with the patch?

[ayushtkn]

@abstractdog I tried the UT's present in the code. The error message looked like

Node: ayushsaxena/192.168.29.11 : Error while running task ( failure ) : attempt_10000_0001_1_01_000001_1:org.apache.tez.dag.api.TezReflectionException: Unable to load class: NotExitedProcessor
	at org.apache.tez.common.ReflectionUtils.getClazz(ReflectionUtils.java:45)
	at org.apache.tez.common.ReflectionUtils.createClazzInstance(ReflectionUtils.java:86)
	at org.apache.tez.runtime.LogicalIOProcessorRuntimeTask.createProcessor(LogicalIOProcessorRuntimeTask.java:680)
	at org.apache.tez.runtime.LogicalIOProcessorRuntimeTask.initialize(LogicalIOProcessorRuntimeTask.java:241)
	at org.apache.tez.runtime.task.TaskRunner2Callable$1.run(TaskRunner2Callable.java:78)
	at org.apache.tez.runtime.task.TaskRunner2Callable$1.run(TaskRunner2Callable.java:69)
	at java.security.AccessController.doPrivileged(Native Method)
	at javax.security.auth.Subject.doAs(Subject.java:422)
	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1899)
	at org.apache.tez.runtime.task.TaskRunner2Callable.callInternal(TaskRunner2Callable.java:69)
	at org.apache.tez.runtime.task.TaskRunner2Callable.callInternal(TaskRunner2Callable.java:39)
	at org.apache.tez.common.CallableWithNdc.call(CallableWithNdc.java:36)
	at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:131)
	at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:75)
	at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:82)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:750)
Caused by: java.lang.ClassNotFoundException: NotExitedProcessor
	at java.net.URLClassLoader.findClass(URLClassLoader.java:387)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:419)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:352)
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Class.java:348)
	at org.apache.tez.common.ReflectionUtils.getClazz(ReflectionUtils.java:43)
	... 17 more