Skip to content

TEZ-4478: Refactor dependency versions into properties in pom. #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abstractdog merged 1 commit into from
Jun 20, 2023
Merged

TEZ-4478: Refactor dependency versions into properties in pom. #291

abstractdog merged 1 commit into from
Jun 20, 2023

Conversation

@ayushtkn
Copy link
Member

@ayushtkn ayushtkn commented Jun 19, 2023

No description provided.

@tez-yetus

This comment was marked as outdated.

Sign in to view
@tez-yetus
Copy link

tez-yetus commented Jun 19, 2023

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 23m 39s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 6m 12s Maven dependency ordering for branch
+1 💚 mvninstall 11m 41s master passed
+1 💚 compile 7m 49s master passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚 compile 7m 4s master passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚 javadoc 8m 6s master passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚 javadoc 6m 46s master passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 8m 41s the patch passed
+1 💚 compile 7m 47s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚 javac 7m 47s the patch passed
+1 💚 compile 7m 22s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚 javac 7m 22s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 13s The patch has no ill-formed XML file.
+1 💚 javadoc 7m 18s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚 javadoc 6m 45s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
_ Other Tests _
+1 💚 unit 2m 26s tez-api in the patch passed.
+1 💚 unit 0m 54s tez-runtime-internals in the patch passed.
+1 💚 unit 5m 59s tez-runtime-library in the patch passed.
+1 💚 unit 1m 41s tez-mapreduce in the patch passed.
+1 💚 unit 5m 27s tez-dag in the patch passed.
+1 💚 unit 4m 22s tez-ext-service-tests in the patch passed.
+1 💚 unit 0m 42s tez-protobuf-history-plugin in the patch passed.
+1 💚 unit 3m 8s tez-aux-services in the patch passed.
+1 💚 unit 0m 27s docs in the patch passed.
+1 💚 unit 74m 26s root in the patch passed.
+1 💚 asflicense 4m 55s The patch does not generate ASF License warnings.
216m 47s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-291/2/artifact/out/Dockerfile
GITHUB PR #291
JIRA Issue TEZ-4478
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux ac19ad52943d 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 86b1199
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-291/2/testReport/
Max. process+thread count 2100 (vs. ulimit of 5500)
modules C: tez-api tez-runtime-internals tez-runtime-library tez-mapreduce tez-dag tez-ext-service-tests tez-plugins/tez-protobuf-history-plugin tez-plugins/tez-aux-services docs . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-291/2/console
versions git=2.34.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

abstractdog
abstractdog reviewed Jun 19, 2023
View reviewed changes
pom.xml Outdated
<distMgmtStagingName>Apache Release Distribution Repository</distMgmtStagingName>
<distMgmtStagingUrl>https://repository.apache.org/service/local/staging/deploy/maven2</distMgmtStagingUrl>

<!-- dependency versions in alphabetical order-->
Copy link
Contributor

@abstractdog abstractdog Jun 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indent comment with properties

@abstractdog abstractdog self-requested a review June 19, 2023 21:17
abstractdog
abstractdog approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@abstractdog abstractdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, other than that +1

@ayushtkn
TEZ-4478: Refactor dependency versions into properties in pom.
26757de 
Change-Id: Iefa56a3defaad073f439ce30b980853c3a8ce54f
@abstractdog abstractdog merged commit d20f334 into apache:master Jun 20, 2023
@tez-yetus
Copy link

tez-yetus commented Jun 20, 2023

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 19s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 6m 37s Maven dependency ordering for branch
+1 💚 mvninstall 11m 50s master passed
+1 💚 compile 7m 49s master passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚 compile 7m 31s master passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚 javadoc 5m 53s master passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚 javadoc 5m 16s master passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 7m 35s the patch passed
+1 💚 compile 7m 52s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚 javac 7m 52s the patch passed
+1 💚 compile 7m 24s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
+1 💚 javac 7m 24s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 13s The patch has no ill-formed XML file.
+1 💚 javadoc 5m 25s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 💚 javadoc 5m 27s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
_ Other Tests _
+1 💚 unit 2m 31s tez-api in the patch passed.
+1 💚 unit 0m 54s tez-runtime-internals in the patch passed.
+1 💚 unit 6m 4s tez-runtime-library in the patch passed.
+1 💚 unit 1m 39s tez-mapreduce in the patch passed.
+1 💚 unit 5m 26s tez-dag in the patch passed.
+1 💚 unit 4m 31s tez-ext-service-tests in the patch passed.
+1 💚 unit 0m 40s tez-protobuf-history-plugin in the patch passed.
+1 💚 unit 3m 6s tez-aux-services in the patch passed.
+1 💚 unit 0m 25s docs in the patch passed.
+1 💚 unit 74m 58s root in the patch passed.
+1 💚 asflicense 5m 2s The patch does not generate ASF License warnings.
187m 20s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-291/3/artifact/out/Dockerfile
GITHUB PR #291
JIRA Issue TEZ-4478
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux c08df1688944 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / a1a8f20
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu122.04-b09
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-291/3/testReport/
Max. process+thread count 2100 (vs. ulimit of 5500)
modules C: tez-api tez-runtime-internals tez-runtime-library tez-mapreduce tez-dag tez-ext-service-tests tez-plugins/tez-protobuf-history-plugin tez-plugins/tez-aux-services docs . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-291/3/console
versions git=2.34.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abstractdog abstractdog abstractdog approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ayushtkn @tez-yetus @abstractdog