-
Notifications
You must be signed in to change notification settings - Fork 440
TEZ-4471: Precommit fails while building yetus image #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
(!) A patch to the testing environment has been detected. |
|
I haven't been able to reproduce the issue locally, so simply upgraded to the next LTS ubuntu version, seems to work I'm keeping this open for a couple of hours for reviews, then merge it anyway to unblock precommit |
This comment was marked as outdated.
This comment was marked as outdated.
|
(!) A patch to the testing environment has been detected. |
e87a0de to
26cb090
Compare
|
(!) A patch to the testing environment has been detected. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ayushtkn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Anyway good to upgrade to the latest LTS release
|
(!) A patch to the testing environment has been detected. |
665dfb4 to
b0fce54
Compare
|
(!) A patch to the testing environment has been detected. |
|
after some hacking I realized the root cause of installation failures in tez-ui is the absence of the bzip2 package, handling it with the latest commit |
|
So, is there any commit which added the dependency on bzip2? Just curious then why didn't it fail in that PR jenkins report |
|
it's because tez precommit flow depends on which files have been modified, e.g. when you only change the Dockerfile, there is no full precommit run, only the docker image is built actually, the bzip2 change is here: once the precommit passes, I'll simply remove the pom.xml hack |
This comment was marked as outdated.
This comment was marked as outdated.
b0fce54 to
86f867b
Compare
|
(!) A patch to the testing environment has been detected. |
86f867b to
130324f
Compare
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
okay, latest precommit passed, I'm about to proceed with it tomorrow |
|
LGTM +1 |
No description provided.