TEZ-4457. tez.task.launch.cmd-opts default value is not really used b…

[qijiale76]

…y default.

[qijiale76]

The default value(jdk8) of tez.task.launch.cmd-opts is -XX:+PrintGCDetails -verbose:gc -XX:+PrintGCTimeStamps -XX:+UseNUMA -XX:+UseParallelGC. It is useful and should be really used by defalut.

[tez-yetus]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	15m 12s	master passed
+1 💚	compile	0m 47s	master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	compile	0m 46s	master passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	checkstyle	1m 17s	master passed
+1 💚	javadoc	0m 56s	master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	javadoc	0m 54s	master passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+0 🆗	spotbugs	1m 36s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 34s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 23s	the patch passed
+1 💚	compile	0m 24s	the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	javac	0m 24s	the patch passed
+1 💚	compile	0m 22s	the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	javac	0m 22s	the patch passed
+1 💚	checkstyle	0m 13s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 25s	the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	javadoc	0m 27s	the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	findbugs	0m 58s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 13s	tez-api in the patch passed.
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		28m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-251/2/artifact/out/Dockerfile
GITHUB PR	#251
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname	Linux 8356ee7557e6 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/tez.sh
git revision	master / 2fd7df4
Default Java	Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-251/2/testReport/
Max. process+thread count	693 (vs. ulimit of 5500)
modules	C: tez-api U: tez-api
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-251/2/console
versions	git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[abstractdog]

thanks for this patch @qijiale76
can you please add a unit test that validates this issue and the resolution?
a recent commit on cmd opts might give you ideas on that: 06fff5c9c

[abstractdog]

cc: @qijiale76 , can you address my comment above?

[qijiale76]

cc: @qijiale76 , can you address my comment above?

Thanks for your comment, sorry I forgot it eariler, I'll add this unit test this week

[tez-yetus]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	12m 40s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	13m 32s	master passed
+1 💚	compile	0m 24s	master passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚	compile	0m 19s	master passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
+1 💚	checkstyle	1m 15s	master passed
+1 💚	javadoc	0m 37s	master passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚	javadoc	0m 23s	master passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
+0 🆗	spotbugs	1m 17s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 14s	the patch passed
+1 💚	compile	0m 14s	the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚	javac	0m 14s	the patch passed
+1 💚	compile	0m 13s	the patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
+1 💚	javac	0m 13s	the patch passed
+1 💚	checkstyle	0m 7s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 15s	the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚	javadoc	0m 16s	the patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
+1 💚	findbugs	0m 35s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 57s	tez-api in the patch passed.
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		35m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-251/1/artifact/out/Dockerfile
GITHUB PR	#251
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname	Linux 39ac56102cb8 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/tez.sh
git revision	master / 7cd6480
Default Java	Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-251/1/testReport/
Max. process+thread count	372 (vs. ulimit of 5500)
modules	C: tez-api U: tez-api
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-251/1/console
versions	git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.