Skip to content

Conversation

@abstractdog
Copy link
Contributor

tested:
built tez-javadoc-tools procject

cd tez-runtime-library
mvn site

checked ./target/site/apidocs/configs/tez-runtime-default-template.xml

@abstractdog abstractdog requested a review from sidseth July 9, 2022 10:00
@abstractdog
Copy link
Contributor Author

I just picked this up while creating tez 0.10.2, can you please review @sidseth ?

@tez-yetus

This comment was marked as outdated.

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 15m 48s master passed
+1 💚 compile 0m 44s master passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 compile 0m 43s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 1m 19s master passed
+1 💚 javadoc 0m 56s master passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 0m 41s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗 spotbugs 1m 17s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 1m 15s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 15s the patch passed
+1 💚 compile 0m 15s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javac 0m 15s the patch passed
+1 💚 compile 0m 13s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 0m 13s the patch passed
-0 ⚠️ checkstyle 0m 10s tez-tools/tez-javadoc-tools: The patch generated 1 new + 0 unchanged - 1 fixed = 1 total (was 1)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 13s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 0m 12s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 findbugs 0m 29s the patch passed
_ Other Tests _
+1 💚 unit 0m 14s tez-javadoc-tools in the patch passed.
+1 💚 asflicense 0m 17s The patch does not generate ASF License warnings.
25m 13s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-230/2/artifact/out/Dockerfile
GITHUB PR #230
JIRA Issue TEZ-3322
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 0ac630e8179a 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / a192ec4
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-230/2/artifact/out/diff-checkstyle-tez-tools_tez-javadoc-tools.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-230/2/testReport/
Max. process+thread count 95 (vs. ulimit of 5500)
modules C: tez-tools/tez-javadoc-tools U: tez-tools/tez-javadoc-tools
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-230/2/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abstractdog
Copy link
Contributor Author

thanks @ayushtkn for the review!
can you take a look at this @rbalamohan , @sidseth please?

@ayushtkn ayushtkn merged commit a66c903 into apache:master Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants