Skip to content

TEZ-4366: Disk utilization limit fix should be applied to all tez mini clusters #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jteagles merged 2 commits into from
Jan 21, 2022
Merged

TEZ-4366: Disk utilization limit fix should be applied to all tez mini clusters #173

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54fad43
TEZ-4366: Disk utilization limit fix should be applied to all tez min…
abstractdog Jan 4, 2022
aac48d2
TezTestUtils
abstractdog Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions tez-common/src/main/java/org/apache/tez/common/TezUtilsInternal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
import org.apache.hadoop.security.SecurityUtil;
import org.apache.hadoop.util.StringUtils;
import org.apache.hadoop.yarn.api.records.ApplicationId;
import org.apache.hadoop.yarn.conf.YarnConfiguration;
import org.apache.log4j.Appender;
import org.apache.tez.common.io.NonSyncByteArrayOutputStream;
import org.apache.tez.dag.api.DagTypeConverters;
Expand Down Expand Up @@ -359,4 +360,18 @@ public static void setSecurityUtilConfigration(Logger log, Configuration conf) {
throw new TezUncheckedException("Error invoking SecurityUtil.setConfiguration", e);
}
}

/**
* Ensures a reasonably high limit for yarn disk utilization. This is very important for tests,
* as devs keep bumping into silent test hangs where yarn simply considers their machines as unhealthy,
* as the default limit is 90%, even if a machine with 90% full disk is still able to function.
* @param conf
*/
public static void ensureHighDiskUtilizationLimit(Configuration conf) {
if (conf.getFloat(YarnConfiguration.NM_MAX_PER_DISK_UTILIZATION_PERCENTAGE,
YarnConfiguration.DEFAULT_NM_MAX_PER_DISK_UTILIZATION_PERCENTAGE) ==
YarnConfiguration.DEFAULT_NM_MAX_PER_DISK_UTILIZATION_PERCENTAGE) {
conf.setFloat(YarnConfiguration.NM_MAX_PER_DISK_UTILIZATION_PERCENTAGE, 99.0f);
}
}
}
7 changes: 7 additions & 0 deletions ...-yarn-timeline-history/src/test/java/org/apache/tez/tests/MiniTezClusterWithTimeline.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
import org.apache.hadoop.yarn.server.MiniYARNCluster;
import org.apache.hadoop.yarn.server.nodemanager.ContainerExecutor;
import org.apache.hadoop.yarn.server.nodemanager.DefaultContainerExecutor;
import org.apache.tez.common.TezUtilsInternal;
import org.apache.tez.dag.api.TezConfiguration;
import org.apache.tez.dag.api.TezUncheckedException;
import org.apache.tez.dag.app.DAGAppMaster;
Expand Down Expand Up @@ -92,6 +93,12 @@ public MiniTezClusterWithTimeline(String testName, int noOfNMs,
super(testName, 1, noOfNMs, numLocalDirs, numLogDirs, enableAHS);
}

@Override
public void init(Configuration conf) {
TezUtilsInternal.ensureHighDiskUtilizationLimit(conf);
super.init(conf);
}

@Override
public void serviceInit(Configuration conf) throws Exception {
conf.set(MRConfig.FRAMEWORK_NAME, MRConfig.YARN_TEZ_FRAMEWORK_NAME);
Expand Down
6 changes: 2 additions & 4 deletions tez-tests/src/test/java/org/apache/tez/test/MiniTezCluster.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
import org.apache.hadoop.yarn.server.MiniYARNCluster;
import org.apache.hadoop.yarn.server.nodemanager.ContainerExecutor;
import org.apache.hadoop.yarn.server.nodemanager.DefaultContainerExecutor;
import org.apache.tez.common.TezUtilsInternal;
import org.apache.tez.dag.api.TezConfiguration;
import org.apache.tez.dag.api.TezUncheckedException;
import org.apache.tez.dag.app.DAGAppMaster;
Expand Down Expand Up @@ -90,10 +91,7 @@ public MiniTezCluster(String testName, int noOfNMs,

@Override
public void init(Configuration conf) {
if (conf.getFloat(YarnConfiguration.NM_MAX_PER_DISK_UTILIZATION_PERCENTAGE,
YarnConfiguration.DEFAULT_NM_MAX_PER_DISK_UTILIZATION_PERCENTAGE) == YarnConfiguration.DEFAULT_NM_MAX_PER_DISK_UTILIZATION_PERCENTAGE) {
conf.setFloat(YarnConfiguration.NM_MAX_PER_DISK_UTILIZATION_PERCENTAGE, 99.0f);
}
TezUtilsInternal.ensureHighDiskUtilizationLimit(conf);
super.init(conf);
}

Expand Down