Skip to content

TEZ-4321: Do Not Wrap Singleton Collections #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jteagles merged 1 commit into from
Aug 9, 2021
Merged

TEZ-4321: Do Not Wrap Singleton Collections #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/BroadcastEdgeManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ public int getNumSourceTaskPhysicalOutputs(int sourceTaskIndex) {
public void routeDataMovementEventToDestination(DataMovementEvent event,
int sourceTaskIndex, int sourceOutputIndex,
Map<Integer, List<Integer>> destinationTaskAndInputIndices) {
List<Integer> inputIndices =
Collections.unmodifiableList(Collections.singletonList(sourceTaskIndex));
List<Integer> inputIndices = Collections.singletonList(sourceTaskIndex);
// for each task make the i-th source task as the i-th physical input
for (int i=0; i<getContext().getDestinationVertexNumTasks(); ++i) {
destinationTaskAndInputIndices.put(i, inputIndices);
Expand Down Expand Up @@ -93,8 +92,7 @@ public EventRouteMetadata routeInputSourceTaskFailedEventToDestination(
@Override
public void routeInputSourceTaskFailedEventToDestination(int sourceTaskIndex,
Map<Integer, List<Integer>> destinationTaskAndInputIndices) {
List<Integer> inputIndices =
Collections.unmodifiableList(Collections.singletonList(sourceTaskIndex));
List<Integer> inputIndices = Collections.singletonList(sourceTaskIndex);
// for each task make the i-th source task as the i-th physical input
for (int i=0; i<getContext().getDestinationVertexNumTasks(); ++i) {
destinationTaskAndInputIndices.put(i, inputIndices);
Expand Down
3 changes: 1 addition & 2 deletions tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/OneToOneEdgeManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@

public class OneToOneEdgeManager extends EdgeManagerPlugin {

final List<Integer> destinationInputIndices =
Collections.unmodifiableList(Collections.singletonList(0));
final List<Integer> destinationInputIndices = Collections.singletonList(0);
final AtomicBoolean stateChecked = new AtomicBoolean(false);

public OneToOneEdgeManager(EdgeManagerPluginContext context) {
Expand Down
3 changes: 1 addition & 2 deletions tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/OneToOneEdgeManagerOnDemand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@

public class OneToOneEdgeManagerOnDemand extends EdgeManagerPluginOnDemand {

final List<Integer> destinationInputIndices =
Collections.unmodifiableList(Collections.singletonList(0));
final List<Integer> destinationInputIndices = Collections.singletonList(0);
final AtomicBoolean stateChecked = new AtomicBoolean(false);

final EventRouteMetadata commonRouteMeta =
Expand Down
3 changes: 1 addition & 2 deletions tez-dag/src/test/java/org/apache/tez/dag/app/TestMockDAGAppMaster.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,8 +300,7 @@ public void testBasicEvents() throws Exception {
}

public static class LegacyEdgeTestEdgeManager extends EdgeManagerPlugin {
List<Integer> destinationInputIndices =
Collections.unmodifiableList(Collections.singletonList(0));
List<Integer> destinationInputIndices = Collections.singletonList(0);
public LegacyEdgeTestEdgeManager(EdgeManagerPluginContext context) {
super(context);
}
Expand Down