TEZ-4281: dag_*_priority.dot files should go into a valid log directory #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abstractdog
force-pushed
the
TEZ-4281
branch
2 times, most recently
from
6f8dfd4 to
7f964a7
Compare
Contributor
Author
|
@rbalamohan: could you please take a look at this simple patch? |
Contributor
|
+1. Can you exclude get/setLogDirs findbugs before commit? |
rbalamohan
approved these changes
Feb 7, 2021
Contributor
rbalamohan
left a comment
rbalamohan
left a comment
There was a problem hiding this comment.
+1. Can you exclude set/getLogDirs findbugs before commit?
abstractdog
force-pushed
the
TEZ-4281
branch
3 times, most recently
from
4b6873c to
1176bf6
Compare
Change-Id: I611098449116fe764b64888118bfd0ae3e17c084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.