Skip to content

[SPARKR] [HOTFIX] Disable flaky SparkR package build test #9744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shivaram wants to merge 2 commits into from
Closed

[SPARKR] [HOTFIX] Disable flaky SparkR package build test #9744

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efe9c36
Disable flaky SparkR package build test
shivaram Nov 16, 2015
3ca6f13
Use ignore instead of commenting it out
shivaram Nov 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,9 @@ class SparkSubmitSuite
}
}

// TODO(SPARK-9603): Building a package is flaky on Jenkins Maven builds.
// See https://gist.github.com/shivaram/3a2fecce60768a603dac for a error log
/*
test("correctly builds R packages included in a jar with --packages") {
Copy link
Contributor

@andrewor14 andrewor14 Nov 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks OK, but you can just do ignore here instead

Copy link
Contributor

@JoshRosen JoshRosen Nov 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on preferring ignore.

Copy link
Contributor Author

@shivaram shivaram Nov 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok. I was just reverting the commit in #9390 which removed this comment

assume(RUtils.isRInstalled, "R isn't installed on this machine.")
val main = MavenCoordinate("my.great.lib", "mylib", "0.1")
Expand All @@ -388,6 +391,7 @@ class SparkSubmitSuite
runSparkSubmit(args)
}
}
*/

test("resolves command line argument paths correctly") {
val jars = "/jar1,/jar2" // --jars
Expand Down