Skip to content

[SPARK-11191] [SPARK-11311] [SQL] Backports #9664 and #9277 to branch-1.5 #9671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
liancheng wants to merge 2 commits into from
Closed

[SPARK-11191] [SPARK-11311] [SQL] Backports #9664 and #9277 to branch-1.5 #9671

liancheng wants to merge 2 commits into from

Conversation

@liancheng
Copy link
Contributor

@liancheng liancheng commented Nov 12, 2015

The main purpose of this PR is to backport #9664, which depends on #9277.

liancheng
liancheng reviewed Nov 12, 2015
View reviewed changes
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala
Copy link
Contributor Author

@liancheng liancheng Nov 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HiveQl tries to resolve UDTFs using Hive FunctionRegistry during parsing, must wrap it with execution Hive state.

@liancheng liancheng mentioned this pull request Nov 12, 2015
Closed
@SparkQA
Copy link

SparkQA commented Nov 12, 2015

Test build #45756 has finished for PR 9671 at commit 5502d69.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@liancheng
Copy link
Contributor Author

liancheng commented Nov 13, 2015

Hm, I suspect maybe the Jenkins build was executed before #9570 (the ADD JAR issue) was merged to branch-1.5, and thus caused the failure.

@liancheng
Copy link
Contributor Author

liancheng commented Nov 13, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Nov 13, 2015

Test build #45797 has finished for PR 9671 at commit 5502d69.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@liancheng
Copy link
Contributor Author

liancheng commented Nov 14, 2015

The test failure was because a previous test case (HiveThriftBinaryServerSuite.test jdbc cancel) sets spark.sql.hive.thriftServer.async to false. Haven't looked into why this fails ADD JAR, but I think we can address this issue in a separate PR.

@SparkQA
Copy link

SparkQA commented Nov 14, 2015

Test build #45930 has finished for PR 9671 at commit fd7cddb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@liancheng
Copy link
Contributor Author

liancheng commented Nov 15, 2015

cc @yhuai

@yhuai
Copy link
Contributor

yhuai commented Nov 15, 2015

Merge to branch 1.5.

asfgit pushed a commit that referenced this pull request Nov 15, 2015
@liancheng @yhuai
[SPARK-11191][SPARK-11311][SQL] Backports #9664 and #9277 to branch-1.5
b767cee 
The main purpose of this PR is to backport #9664, which depends on #9277.

Author: Cheng Lian <[email protected]>

Closes #9671 from liancheng/spark-11191.fix-temp-function.branch-1_5.
@yhuai
Copy link
Contributor

yhuai commented Nov 15, 2015

Merged.

@liancheng liancheng closed this Nov 16, 2015
@liancheng liancheng deleted the spark-11191.fix-temp-function.branch-1_5 branch November 16, 2015 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liancheng @SparkQA @yhuai