Skip to content

[SPARK-11706][Streaming]Fix the bug that Streaming Python tests cannot report failures #9669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zsxwing wants to merge 6 commits into from
Closed

[SPARK-11706][Streaming]Fix the bug that Streaming Python tests cannot report failures #9669

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bbfea87
Fix the bug that Streaming Python tests cannot report failures
zsxwing Nov 12, 2015
1f3764b
Fix XMLTestRunner
zsxwing Nov 12, 2015
1ea7a52
Initialize the attributes
zsxwing Nov 12, 2015
08d0f60
Fix Streaming Python unit tests
zsxwing Nov 12, 2015
36ae6ba
Fix the code style
zsxwing Nov 12, 2015
a5699e0
Disable CheckpointTests.test_get_or_create_and_get_active_or_create
zsxwing Nov 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions python/pyspark/streaming/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1322,11 +1322,16 @@ def search_kinesis_asl_assembly_jar():
"or 'build/mvn -Pkinesis-asl package' before running this test.")

sys.stderr.write("Running tests: %s \n" % (str(testcases)))
failed = False
for testcase in testcases:
sys.stderr.write("[Running %s]\n" % (testcase))
tests = unittest.TestLoader().loadTestsFromTestCase(testcase)
if xmlrunner:
Copy link
Member Author

@zsxwing zsxwing Nov 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unittest.main will call sys.exit after finishing tests, so we should not use it here.

unittest.main(tests, verbosity=3,
testRunner=xmlrunner.XMLTestRunner(output='target/test-reports'))
result = xmlrunner.XMLTestRunner(output='target/test-reports', verbosity=3).run(tests)
if not result.wasSuccessful():
failed = True
else:
unittest.TextTestRunner(verbosity=3).run(tests)
result = unittest.TextTestRunner(verbosity=3).run(tests)
if not result.wasSuccessful():
failed = True
sys.exit(failed)