Skip to content

[SPARK-11311] [SQL] spark cannot describe temporary functions #9277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adrian-wang wants to merge 2 commits into from
Closed

[SPARK-11311] [SQL] spark cannot describe temporary functions #9277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1c0a98
fix temporary function description
adrian-wang Oct 26, 2015
50bdef7
refine test
adrian-wang Oct 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,11 @@ private[hive] class HiveFunctionRegistry(underlying: analysis.FunctionRegistry)
annotation.value(),
annotation.extended()))
} else {
None
Some(new ExpressionInfo(
info.getFunctionClass.getCanonicalName,
name,
null,
null))
Copy link
Contributor

@yhuai yhuai Nov 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When will we hit this branch? For Hive UDFs, this fixes the problem because UDFs do not have annotation?

Copy link
Contributor Author

@adrian-wang adrian-wang Nov 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we register a function using create function xx as "org.....", sometimes there's no annotation, but spark would complain could not find this function.

}
}.getOrElse(None))
}
Expand Down
10 changes: 10 additions & 0 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,6 +899,16 @@ class HiveQuerySuite extends HiveComparisonTest with BeforeAndAfter {
sql("DROP TABLE t1")
}

test("CREATE TEMPORARY FUNCTION") {
val funcJar = TestHive.getHiveFile("TestUDTF.jar").getCanonicalPath
sql(s"ADD JAR $funcJar")
sql(
"""CREATE TEMPORARY FUNCTION udtf_count2 AS
| 'org.apache.spark.sql.hive.execution.GenericUDTFCount2'""".stripMargin)
assert(sql("DESCRIBE FUNCTION udtf_count2").count > 1)
sql("DROP TEMPORARY FUNCTION udtf_count2")
}

test("ADD FILE command") {
val testFile = TestHive.getHiveFile("data/files/v1.txt").getCanonicalFile
sql(s"ADD FILE $testFile")
Expand Down