-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-11063][Streaming]Change preferredLocations of Receiver's RDD to hosts rather than hostports #9075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[SPARK-11063][Streaming]Change preferredLocations of Receiver's RDD to hosts rather than hostports #9075
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,8 @@ import scala.collection.mutable.ArrayBuffer | |
| import org.scalatest.concurrent.Eventually._ | ||
| import org.scalatest.time.SpanSugar._ | ||
|
|
||
| import org.apache.spark.scheduler.{SparkListener, SparkListenerTaskStart, TaskLocality} | ||
| import org.apache.spark.scheduler.TaskLocality.TaskLocality | ||
| import org.apache.spark.storage.{StorageLevel, StreamBlockId} | ||
| import org.apache.spark.streaming._ | ||
| import org.apache.spark.streaming.dstream.ReceiverInputDStream | ||
|
|
@@ -80,6 +82,28 @@ class ReceiverTrackerSuite extends TestSuiteBase { | |
| } | ||
| } | ||
| } | ||
|
|
||
| test("SPARK-11063: TaskSetManager should use Receiver RDD's preferredLocations") { | ||
| // Use ManualClock to prevent from starting batches so that we can make sure the only task is | ||
| // for starting the Receiver | ||
| val _conf = conf.clone.set("spark.streaming.clock", "org.apache.spark.util.ManualClock") | ||
| withStreamingContext(new StreamingContext(_conf, Milliseconds(100))) { ssc => | ||
| @volatile var receiverTaskLocality: TaskLocality = null | ||
| ssc.sparkContext.addSparkListener(new SparkListener { | ||
| override def onTaskStart(taskStart: SparkListenerTaskStart): Unit = { | ||
| receiverTaskLocality = taskStart.taskInfo.taskLocality | ||
| } | ||
| }) | ||
| val input = ssc.receiverStream(new TestReceiver) | ||
| val output = new TestOutputStream(input) | ||
| output.register() | ||
| ssc.start() | ||
| eventually(timeout(10 seconds), interval(10 millis)) { | ||
| // If preferredLocations is set correctly, receiverTaskLocality should be NODE_LOCAL | ||
| assert(receiverTaskLocality === TaskLocality.NODE_LOCAL) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What will it be if it is not set correctly? That is, without the fix above, what would locality be
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's |
||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /** An input DStream with for testing rate controlling */ | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CodingCat could you take a look at this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, will do tomorrow morning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a significant bug in the core. If so probably go into a separate patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And how is this related to the main bug we are considering in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not related. I will move it in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm....it's a typo but would not take any effect
see discussions here: #3816 (only look at the comments after Dec 30, 2014 is enough)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't notice this PR. Thanks.