-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-10393] use ML pipeline in LDA example #8551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #41868 has finished for PR 8551 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we revert these NOOP changes (here and stopwordFile) since there's no style guide violation here?
|
@feynmanliang Thanks for the review. I'll update later today. |
|
@feynmanliang @jkbradley Sorry for the late update. |
|
Test build #43561 has finished for PR 8551 at commit
|
|
download failed: org.apache.spark#spark-unsafe_2.10;1.5.0!spark-unsafe_2.10.jar need to trigger the test again? |
|
Test build #2026 has finished for PR 8551 at commit
|
|
unrelated UT timeout failure: SPARK-11188 Analysis error reporting *** FAILED *** (2 minutes) |
|
Jenkins retest this please |
|
Test build #45515 has finished for PR 8551 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure about removing the scalastyle line?
|
Test build #2177 has finished for PR 8551 at commit
|
|
Those 3 items (thanks @BenFradet ) are the only issues I see. Thanks! |
|
Thanks @jkbradley @BenFradet for the review. |
|
Test build #47324 has finished for PR 8551 at commit
|
|
LGTM. Merging with master and branch-1.6 Thank you! |
jira: https://issues.apache.org/jira/browse/SPARK-10393 Since the logic of the text processing part has been moved to ML estimators/transformers, replace the related code in LDA Example with the ML pipeline. Author: Yuhao Yang <[email protected]> Author: yuhaoyang <[email protected]> Closes #8551 from hhbyyh/ldaExUpdate. (cherry picked from commit 872a2ee) Signed-off-by: Joseph K. Bradley <[email protected]>
jira: https://issues.apache.org/jira/browse/SPARK-10393
Since the logic of the text processing part has been moved to ML estimators/transformers, replace the related code in LDA Example with the ML pipeline.