Skip to content

Conversation

@hhbyyh
Copy link
Contributor

@hhbyyh hhbyyh commented Sep 1, 2015

jira: https://issues.apache.org/jira/browse/SPARK-10393

Since the logic of the text processing part has been moved to ML estimators/transformers, replace the related code in LDA Example with the ML pipeline.

@SparkQA
Copy link

SparkQA commented Sep 1, 2015

Test build #41868 has finished for PR 8551 at commit 84cc1be.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class DCT(JavaTransformer, HasInputCol, HasOutputCol):
    • class SQLTransformer(JavaTransformer):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revert these NOOP changes (here and stopwordFile) since there's no style guide violation here?

@hhbyyh
Copy link
Contributor Author

hhbyyh commented Sep 15, 2015

@feynmanliang Thanks for the review. I'll update later today.

@hhbyyh
Copy link
Contributor Author

hhbyyh commented Oct 12, 2015

@feynmanliang @jkbradley Sorry for the late update.

@SparkQA
Copy link

SparkQA commented Oct 12, 2015

Test build #43561 has finished for PR 8551 at commit ee4832d.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@hhbyyh
Copy link
Contributor Author

hhbyyh commented Oct 12, 2015

download failed: org.apache.spark#spark-unsafe_2.10;1.5.0!spark-unsafe_2.10.jar

need to trigger the test again?

@SparkQA
Copy link

SparkQA commented Nov 10, 2015

Test build #2026 has finished for PR 8551 at commit ee4832d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@hhbyyh
Copy link
Contributor Author

hhbyyh commented Nov 10, 2015

unrelated UT timeout failure:

SPARK-11188 Analysis error reporting *** FAILED *** (2 minutes)
[info] =======================
[info] CliSuite failure output
[info] =======================
[info] Spark SQL CLI command line: ../../bin/spark-sql --master local --hiveconf

@feynmanliang
Copy link
Contributor

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented Nov 10, 2015

Test build #45515 has finished for PR 8551 at commit ee4832d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about removing the scalastyle line?

@SparkQA
Copy link

SparkQA commented Dec 7, 2015

Test build #2177 has finished for PR 8551 at commit ee4832d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

Those 3 items (thanks @BenFradet ) are the only issues I see. Thanks!

@hhbyyh
Copy link
Contributor Author

hhbyyh commented Dec 8, 2015

Thanks @jkbradley @BenFradet for the review.

@SparkQA
Copy link

SparkQA commented Dec 8, 2015

Test build #47324 has finished for PR 8551 at commit 672ce97.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

LGTM. Merging with master and branch-1.6

Thank you!

asfgit pushed a commit that referenced this pull request Dec 8, 2015
jira: https://issues.apache.org/jira/browse/SPARK-10393

Since the logic of the text processing part has been moved to ML estimators/transformers, replace the related code in LDA Example with the ML pipeline.

Author: Yuhao Yang <[email protected]>
Author: yuhaoyang <[email protected]>

Closes #8551 from hhbyyh/ldaExUpdate.

(cherry picked from commit 872a2ee)
Signed-off-by: Joseph K. Bradley <[email protected]>
@asfgit asfgit closed this in 872a2ee Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants