Skip to content

[SPARK-5768] [Web UI] Fix for incorrect memory in Spark UI #6972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rekhajoshm wants to merge 6 commits into from
Closed

[SPARK-5768] [Web UI] Fix for incorrect memory in Spark UI #6972

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e3677c9
Merge pull request #1 from apache/master
rekhajoshm May 5, 2015
106fd8e
Merge pull request #2 from apache/master
rekhajoshm May 8, 2015
0be142d
Merge pull request #3 from apache/master
rekhajoshm Jun 22, 2015
eb823b8
SPARK-5768: Fix for incorrect memory in Spark UI
rekhajoshm Jun 24, 2015
2fe53d9
Fix for incorrect memory in Spark UI
rekhajoshm Jun 25, 2015
b678a91
Fix for incorrect memory in Spark UI
rekhajoshm Jun 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/src/main/scala/org/apache/spark/ui/ToolTips.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ private[spark] object ToolTips {

val OUTPUT = "Bytes and records written to Hadoop."

val STORAGE_MEMORY =
"Total memory used for caching of the total available memory for caching.This is the storage memory used on the executor."
Copy link
Member

@sarutak sarutak Jun 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, storage memory is used by not only cached-RDD right?

Copy link
Member

@srowen srowen Jun 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest something like "Memory used / total available for storage of data like RDD partitions cached in memory"?


Copy link
Member

@sarutak sarutak Jun 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this text is enclosed by triple-double-quote? It bring needless new line.
How about make the text like as follows?

"Memory used / total available memory for storage of data " +
  "like RDD partitions cached in memory. "

val SHUFFLE_WRITE =
"Bytes and records written to disk in order to be read by a shuffle in a future stage."

Expand Down
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ private[ui] class ExecutorsPage(
<th>Executor ID</th>
<th>Address</th>
<th>RDD Blocks</th>
<th>Memory Used</th>
<th><span data-toggle="tooltip" title={ToolTips.STORAGE_MEMORY}>Storage Memory</span></th>
<th>Disk Used</th>
<th>Active Tasks</th>
<th>Failed Tasks</th>
Expand Down