Skip to content

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented May 6, 2015

The bug is because SPARK-7139 removed some codes from SPARK-7112 unintentionally here: 1854ac3#diff-5c8651dd78abd20439b8eb938175075dL72

This PR just added them back and added some assertions in the tests to verify it.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #32023 has started for PR 5950 at commit 675f5d9.

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #32023 has finished for PR 5950 at commit 675f5d9.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32023/
Test FAILed.

@zsxwing
Copy link
Member Author

zsxwing commented May 6, 2015

retest this please.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #32043 has started for PR 5950 at commit 675f5d9.

@tdas
Copy link
Contributor

tdas commented May 7, 2015

That was super-unfortunate. And I missed it as well. It shows that we didnt have sufficient test coverage on that. LGTM, will merge when tests pass.

@SparkQA
Copy link

SparkQA commented May 7, 2015

Test build #32043 has finished for PR 5950 at commit 675f5d9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32043/
Test PASSed.

@tdas
Copy link
Contributor

tdas commented May 7, 2015

Merging.

asfgit pushed a commit that referenced this pull request May 7, 2015
…t report InputInfo

The bug is because SPARK-7139 removed some codes from SPARK-7112 unintentionally here: 1854ac3#diff-5c8651dd78abd20439b8eb938175075dL72

This PR just added them back and added some assertions in the tests to verify it.

Author: zsxwing <[email protected]>

Closes #5950 from zsxwing/SPARK-7405 and squashes the following commits:

675f5d9 [zsxwing] Fix the bug that ReceiverInputDStream doesn't report InputInfo

(cherry picked from commit 14502d5)
Signed-off-by: Tathagata Das <[email protected]>
@asfgit asfgit closed this in 14502d5 May 7, 2015
@zsxwing zsxwing deleted the SPARK-7405 branch May 7, 2015 01:10
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
…t report InputInfo

The bug is because SPARK-7139 removed some codes from SPARK-7112 unintentionally here: apache@1854ac3#diff-5c8651dd78abd20439b8eb938175075dL72

This PR just added them back and added some assertions in the tests to verify it.

Author: zsxwing <[email protected]>

Closes apache#5950 from zsxwing/SPARK-7405 and squashes the following commits:

675f5d9 [zsxwing] Fix the bug that ReceiverInputDStream doesn't report InputInfo
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
…t report InputInfo

The bug is because SPARK-7139 removed some codes from SPARK-7112 unintentionally here: apache@1854ac3#diff-5c8651dd78abd20439b8eb938175075dL72

This PR just added them back and added some assertions in the tests to verify it.

Author: zsxwing <[email protected]>

Closes apache#5950 from zsxwing/SPARK-7405 and squashes the following commits:

675f5d9 [zsxwing] Fix the bug that ReceiverInputDStream doesn't report InputInfo
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
…t report InputInfo

The bug is because SPARK-7139 removed some codes from SPARK-7112 unintentionally here: apache@1854ac3#diff-5c8651dd78abd20439b8eb938175075dL72

This PR just added them back and added some assertions in the tests to verify it.

Author: zsxwing <[email protected]>

Closes apache#5950 from zsxwing/SPARK-7405 and squashes the following commits:

675f5d9 [zsxwing] Fix the bug that ReceiverInputDStream doesn't report InputInfo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants