Skip to content

Update GradientDescentSuite.scala #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
baishuo wants to merge 3 commits into from
Closed

Update GradientDescentSuite.scala #588

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b666d27
Update GradientDescentSuite.scala
baishuo Apr 29, 2014
c03b61c
Update GradientDescentSuite.scala
baishuo Apr 29, 2014
45b95fb
Update GradientDescentSuite.scala
baishuo Apr 30, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mllib/src/test/scala/org/apache/spark/mllib/optimization/GradientDescentSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,11 @@ class GradientDescentSuite extends FunSuite with LocalSparkContext with ShouldMa
// Add a extra variable consisting of all 1.0's for the intercept.
val testData = GradientDescentSuite.generateGDInput(A, B, nPoints, 42)
val data = testData.map { case LabeledPoint(label, features) =>
label -> Vectors.dense(1.0, features.toArray: _*)
label -> (1.0 +: features)
Copy link
Contributor

@techaddict techaddict Apr 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't compile either, we need to write features +: 1.0

Copy link
Contributor

@techaddict techaddict Apr 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for other changes too.

}

val dataRDD = sc.parallelize(data, 2).cache()
val initialWeightsWithIntercept = Vectors.dense(1.0, initialWeights: _*)
val initialWeightsWithIntercept = 1.0 +: initialWeights

val (_, loss) = GradientDescent.runMiniBatchSGD(
dataRDD,
Expand All @@ -111,7 +111,7 @@ class GradientDescentSuite extends FunSuite with LocalSparkContext with ShouldMa
// Add a extra variable consisting of all 1.0's for the intercept.
val testData = GradientDescentSuite.generateGDInput(2.0, -1.5, 10000, 42)
val data = testData.map { case LabeledPoint(label, features) =>
label -> Vectors.dense(1.0, features.toArray: _*)
label -> (1.0 +: features)
}

val dataRDD = sc.parallelize(data, 2).cache()
Expand Down