Skip to content

[SPARK-7305][Streaming][WebUI] Make BatchPage show friendly information when jobs are dropped by SparkListener #5840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zsxwing wants to merge 4 commits into from
Closed

[SPARK-7305][Streaming][WebUI] Make BatchPage show friendly information when jobs are dropped by SparkListener #5840

zsxwing wants to merge 4 commits into from

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented May 1, 2015

If jobs are dropped by SparkListener, at least we can show the job ids in BatchPage. Screenshot:

b1

@zsxwing
Copy link
Member Author

zsxwing commented May 1, 2015

cc @tdas

@AmplabJenkins
Copy link

AmplabJenkins commented May 1, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 1, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 1, 2015

Test build #31580 has started for PR 5840 at commit 83dec11.

@SparkQA
Copy link

SparkQA commented May 1, 2015

Test build #31580 has finished for PR 5840 at commit 83dec11.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • final class Binarizer extends Transformer with HasInputCol with HasOutputCol

@AmplabJenkins
Copy link

AmplabJenkins commented May 1, 2015

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 1, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31580/
Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 6, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 6, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #31999 has started for PR 5840 at commit 8073b03.

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #31999 has finished for PR 5840 at commit 8073b03.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 6, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 6, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31999/
Test FAILed.

@zsxwing
Copy link
Member Author

zsxwing commented May 6, 2015

retest this please.

@AmplabJenkins
Copy link

AmplabJenkins commented May 6, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 6, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #32008 has started for PR 5840 at commit 8073b03.

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #32008 has finished for PR 5840 at commit 8073b03.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 6, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 6, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32008/
Test FAILed.

@zsxwing
Copy link
Member Author

zsxwing commented May 6, 2015

retest this please.

@AmplabJenkins
Copy link

AmplabJenkins commented May 6, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 6, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #32020 has started for PR 5840 at commit 8073b03.

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #32020 has finished for PR 5840 at commit 8073b03.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 6, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 6, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32020/
Test FAILed.

@zsxwing
Copy link
Member Author

zsxwing commented May 6, 2015

retest this please.

tdas
tdas reviewed May 7, 2015
View reviewed changes
streaming/src/main/scala/org/apache/spark/streaming/ui/BatchPage.scala Outdated
Copy link
Contributor

@tdas tdas May 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This is a little weird to read with the continuous line having a line of comment in the middle. took 5 seconds to realize that this is a continuation line.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 7, 2015

Test build #32134 has started for PR 5840 at commit 718765e.

@SparkQA
Copy link

SparkQA commented May 7, 2015

Test build #32134 has finished for PR 5840 at commit 718765e.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32134/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 7, 2015

Test build #32137 has started for PR 5840 at commit aca0ba6.

@tdas
Copy link
Contributor

tdas commented May 7, 2015

LGTM. Will merge when tests pass.

@SparkQA
Copy link

SparkQA commented May 7, 2015

Test build #32137 has finished for PR 5840 at commit aca0ba6.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32137/
Test FAILed.

@zsxwing
Copy link
Member Author

zsxwing commented May 7, 2015

retest this please

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Merged build started.

@SparkQA
Copy link

SparkQA commented May 7, 2015

Test build #32148 has started for PR 5840 at commit aca0ba6.

@SparkQA
Copy link

SparkQA commented May 7, 2015

Test build #32148 has finished for PR 5840 at commit aca0ba6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented May 7, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32148/
Test PASSed.

asfgit pushed a commit that referenced this pull request May 8, 2015
@zsxwing @tdas
[SPARK-7305] [STREAMING] [WEBUI] Make BatchPage show friendly informa…
2e8a141 
…tion when jobs are dropped by SparkListener

If jobs are dropped by SparkListener, at least we can show the job ids in BatchPage. Screenshot:

![b1](https://cloud.githubusercontent.com/assets/1000778/7434968/f19aa784-eff3-11e4-8f86-36a073873574.png)

Author: zsxwing <[email protected]>

Closes #5840 from zsxwing/SPARK-7305 and squashes the following commits:

aca0ba6 [zsxwing] Fix the code style
718765e [zsxwing] Make generateNormalJobRow private
8073b03 [zsxwing] Merge branch 'master' into SPARK-7305
83dec11 [zsxwing] Make BatchPage show friendly information when jobs are dropped by SparkListener

(cherry picked from commit 22ab70e)
Signed-off-by: Tathagata Das <[email protected]>
@asfgit asfgit closed this in 22ab70e May 8, 2015
@zsxwing zsxwing deleted the SPARK-7305 branch May 8, 2015 00:36
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@zsxwing @jeanlyn
[SPARK-7305] [STREAMING] [WEBUI] Make BatchPage show friendly informa…
7d330b2 
…tion when jobs are dropped by SparkListener

If jobs are dropped by SparkListener, at least we can show the job ids in BatchPage. Screenshot:

![b1](https://cloud.githubusercontent.com/assets/1000778/7434968/f19aa784-eff3-11e4-8f86-36a073873574.png)

Author: zsxwing <[email protected]>

Closes apache#5840 from zsxwing/SPARK-7305 and squashes the following commits:

aca0ba6 [zsxwing] Fix the code style
718765e [zsxwing] Make generateNormalJobRow private
8073b03 [zsxwing] Merge branch 'master' into SPARK-7305
83dec11 [zsxwing] Make BatchPage show friendly information when jobs are dropped by SparkListener
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@zsxwing @jeanlyn
[SPARK-7305] [STREAMING] [WEBUI] Make BatchPage show friendly informa…
2e200a3 
…tion when jobs are dropped by SparkListener

If jobs are dropped by SparkListener, at least we can show the job ids in BatchPage. Screenshot:

![b1](https://cloud.githubusercontent.com/assets/1000778/7434968/f19aa784-eff3-11e4-8f86-36a073873574.png)

Author: zsxwing <[email protected]>

Closes apache#5840 from zsxwing/SPARK-7305 and squashes the following commits:

aca0ba6 [zsxwing] Fix the code style
718765e [zsxwing] Make generateNormalJobRow private
8073b03 [zsxwing] Merge branch 'master' into SPARK-7305
83dec11 [zsxwing] Make BatchPage show friendly information when jobs are dropped by SparkListener
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@zsxwing @nemccarthy
[SPARK-7305] [STREAMING] [WEBUI] Make BatchPage show friendly informa…
6428ea7 
…tion when jobs are dropped by SparkListener

If jobs are dropped by SparkListener, at least we can show the job ids in BatchPage. Screenshot:

![b1](https://cloud.githubusercontent.com/assets/1000778/7434968/f19aa784-eff3-11e4-8f86-36a073873574.png)

Author: zsxwing <[email protected]>

Closes apache#5840 from zsxwing/SPARK-7305 and squashes the following commits:

aca0ba6 [zsxwing] Fix the code style
718765e [zsxwing] Make generateNormalJobRow private
8073b03 [zsxwing] Merge branch 'master' into SPARK-7305
83dec11 [zsxwing] Make BatchPage show friendly information when jobs are dropped by SparkListener
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zsxwing @AmplabJenkins @SparkQA @tdas