Skip to content

Conversation

@JoshRosen
Copy link
Contributor

We should upgrade our snappy-java dependency to 1.1.1.7 in order to include a fix for a bug that results in worse compression in SnappyOutputStream (see xerial/snappy-java#100).

@SparkQA
Copy link

SparkQA commented Apr 14, 2015

Test build #30261 has started for PR 5512 at commit f1ac0f8.

@JoshRosen
Copy link
Contributor Author

I hope that this fixes https://issues.apache.org/jira/browse/SPARK-5081, a bug that caused shuffle sizes to increase in 1.2.0, but I filed a separate JIRA for this patch just in case the shuffle size increase has multiple contributing causes.

@SparkQA
Copy link

SparkQA commented Apr 14, 2015

Test build #30261 has finished for PR 5512 at commit f1ac0f8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch adds the following new dependencies:
    • snappy-java-1.1.1.7.jar
  • This patch removes the following dependencies:
    • snappy-java-1.1.1.6.jar

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30261/
Test PASSed.

@JoshRosen
Copy link
Contributor Author

I'm going to merge this into master (1.4.0), branch-1.3 (1.3.2), and branch-1.2 (1.2.3).

@asfgit asfgit closed this in 6adb8bc Apr 14, 2015
asfgit pushed a commit that referenced this pull request Apr 14, 2015
We should upgrade our snappy-java dependency to 1.1.1.7 in order to include a fix for a bug that results in worse compression in SnappyOutputStream (see xerial/snappy-java#100).

Author: Josh Rosen <[email protected]>

Closes #5512 from JoshRosen/snappy-1.1.1.7 and squashes the following commits:

f1ac0f8 [Josh Rosen] Upgrade to snappy-java 1.1.1.7.

(cherry picked from commit 6adb8bc)
Signed-off-by: Josh Rosen <[email protected]>

Conflicts:
	pom.xml
asfgit pushed a commit that referenced this pull request Apr 14, 2015
We should upgrade our snappy-java dependency to 1.1.1.7 in order to include a fix for a bug that results in worse compression in SnappyOutputStream (see xerial/snappy-java#100).

Author: Josh Rosen <[email protected]>

Closes #5512 from JoshRosen/snappy-1.1.1.7 and squashes the following commits:

f1ac0f8 [Josh Rosen] Upgrade to snappy-java 1.1.1.7.

(cherry picked from commit 6adb8bc)
Signed-off-by: Josh Rosen <[email protected]>

Conflicts:
	pom.xml
@ash211
Copy link
Contributor

ash211 commented Apr 15, 2015

Really appreciate this work @JoshRosen !

mingyukim pushed a commit to palantir/spark that referenced this pull request Apr 17, 2015
We should upgrade our snappy-java dependency to 1.1.1.7 in order to include a fix for a bug that results in worse compression in SnappyOutputStream (see xerial/snappy-java#100).

Author: Josh Rosen <[email protected]>

Closes apache#5512 from JoshRosen/snappy-1.1.1.7 and squashes the following commits:

f1ac0f8 [Josh Rosen] Upgrade to snappy-java 1.1.1.7.

(cherry picked from commit 6adb8bc)
Signed-off-by: Josh Rosen <[email protected]>

Conflicts:
	pom.xml
mccheah pushed a commit to palantir/spark that referenced this pull request May 15, 2015
We should upgrade our snappy-java dependency to 1.1.1.7 in order to include a fix for a bug that results in worse compression in SnappyOutputStream (see xerial/snappy-java#100).

Author: Josh Rosen <[email protected]>

Closes apache#5512 from JoshRosen/snappy-1.1.1.7 and squashes the following commits:

f1ac0f8 [Josh Rosen] Upgrade to snappy-java 1.1.1.7.

(cherry picked from commit 6adb8bc)
Signed-off-by: Josh Rosen <[email protected]>

Conflicts:
	pom.xml
@JoshRosen JoshRosen deleted the snappy-1.1.1.7 branch May 26, 2015 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants