Skip to content

[SPARK-55266][INFRA] Add pre-commit hooks for format/lint #54048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaogaotiantian wants to merge 2 commits into from
Closed

[SPARK-55266][INFRA] Add pre-commit hooks for format/lint #54048

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2902cf
Add pre-commit hooks for format/lint
gaogaotiantian Jan 29, 2026
ca2995d
Add license header
gaogaotiantian Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

repos:
- repo: local
hooks:
- id: format-python
name: Format Python code
entry: ./dev/reformat-python
language: system
types: [python]
pass_filenames: false

- id: ruff
name: Lint Python code with Ruff
entry: ./dev/lint-python --ruff
Copy link
Copy Markdown
Contributor

@zhengruifeng zhengruifeng Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, we don't check mypy which is pretty slow (and flaky in my local).
Then LGTM

Copy link
Copy Markdown
Contributor

@Yicong-Huang Yicong-Huang Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is slow because mypy is checking all the dependencies. can we let it not to do it?

Copy link
Copy Markdown
Contributor Author

@gaogaotiantian gaogaotiantian Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mypy is slow, especially without cache. It's pure python. astral and meta are both working on a rust-based type checker which are significantly faster than mypy, but neither of them is stable enough for production use.

language: system
types: [python]
pass_filenames: false