Skip to content

[SPARK-49872][CORE] Remove jackson JSON string length limitation #52049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cloud-fan wants to merge 2 commits into from
Closed

[SPARK-49872][CORE] Remove jackson JSON string length limitation #52049

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
198b6c5
Remove jackson JSON string length limitation.
cloud-fan Aug 16, 2025
95482dc
Update JsonProtocol.scala
cloud-fan Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion core/src/main/scala/org/apache/spark/util/JsonProtocol.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import java.util.{Properties, UUID}
import scala.collection.Map
import scala.jdk.CollectionConverters._

import com.fasterxml.jackson.core.JsonGenerator
import com.fasterxml.jackson.core.{JsonGenerator, StreamReadConstraints}
import com.fasterxml.jackson.databind.JsonNode
import org.json4s.jackson.JsonMethods.compact

Expand Down Expand Up @@ -66,6 +66,11 @@ private[spark] class JsonProtocolOptions(conf: SparkConf) {
private[spark] object JsonProtocol extends JsonUtils {
// TODO: Remove this file and put JSON serialization into each individual class.

// SPARK-49872: Remove jackson JSON string length limitation.
mapper.getFactory.setStreamReadConstraints(
StreamReadConstraints.builder().maxStringLength(Int.MaxValue).build()
Copy link
Member

@dongjoon-hyun dongjoon-hyun Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the compilation failure, @cloud-fan ?

[error] /home/runner/work/spark/spark/core/src/main/scala/org/apache/spark/util/JsonProtocol.scala:71:5: not found: value StreamReadConstraints
[error]     StreamReadConstraints.builder().maxStringLength(Int.MaxValue).build()
[error]     ^
[error] one error found

)

private[util]
val defaultOptions: JsonProtocolOptions = new JsonProtocolOptions(new SparkConf(false))

Expand Down