[SPARK-49791][SQL] Make DelegatingCatalogExtension more extendable #48257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaooqinn
approved these changes
Sep 26, 2024
HyukjinKwon
approved these changes
Sep 26, 2024
This was referenced Sep 26, 2024
cloud-fan
commented
Sep 26, 2024
...atalyst/src/main/java/org/apache/spark/sql/connector/catalog/DelegatingCatalogExtension.java
Outdated
Show resolved
Hide resolved
…log/DelegatingCatalogExtension.java
dongjoon-hyun
approved these changes
Sep 26, 2024
Member
There was a problem hiding this comment.
+1, LGTM.
To @cloud-fan ,
- Do we need to
@DeveloperApiannotation additionally? - Do you want to backport this to
branch-3.5?
RussellSpitzer
approved these changes
Sep 26, 2024
Contributor
Author
|
Hi @dongjoon-hyun , the entire And yes, we want to backport this to 3.5. |
Member
|
Merged to master/3.5! Thank you, @cloud-fan and all! |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 26, 2024
### What changes were proposed in this pull request? This PR updates `DelegatingCatalogExtension` so that it's more extendable - `initialize` becomes not final, so that sub-classes can overwrite it - `delegate` becomes `protected`, so that sub-classes can access it In addition, this PR fixes a mistake that `DelegatingCatalogExtension` is just a convenient default implementation, it's actually the `CatalogExtension` interface that indicates this catalog implementation will delegate requests to the Spark session catalog. #47724 should use `CatalogExtension` instead. ### Why are the changes needed? Unblock the Iceberg extension. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests ### Was this patch authored or co-authored using generative AI tooling? no Closes #48257 from cloud-fan/catalog. Lead-authored-by: Wenchen Fan <[email protected]> Co-authored-by: Wenchen Fan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 339dd5b) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
added a commit
that referenced
this pull request
Sep 26, 2024
### What changes were proposed in this pull request? This PR is a follow-up for `branch-3.5` due to the difference of `import` statement. - #48257 ### Why are the changes needed? To fix the compilation. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #48271 from dongjoon-hyun/SPARK-49791. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
|
Hi @dongjoon-hyun @cloud-fan Could you please let me know if there is a plan or scheduled release date for Spark-354? thanks, -yuan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates
DelegatingCatalogExtensionso that it's more extendableinitializebecomes not final, so that sub-classes can overwrite itdelegatebecomesprotected, so that sub-classes can access itIn addition, this PR fixes a mistake that
DelegatingCatalogExtensionis just a convenient default implementation, it's actually theCatalogExtensioninterface that indicates this catalog implementation will delegate requests to the Spark session catalog. #47724 should useCatalogExtensioninstead.Why are the changes needed?
Unblock the Iceberg extension.
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests
Was this patch authored or co-authored using generative AI tooling?
no