[SPARK-49509][CORE] Use Platform.allocateDirectBuffer instead of ByteBuffer.allocateDirect
#47987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaooqinn
approved these changes
Sep 4, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
I also confirmed that these three are the only instances in main code.
$ git grep ByteBuffer.allocateDirect | grep -v Platform | grep -v test
core/src/main/java/org/apache/spark/io/NioBufferedFileInputStream.java: byteBuffer = ByteBuffer.allocateDirect(bufferSizeInBytes);
core/src/main/scala/org/apache/spark/storage/DiskStore.scala: private val buffer = ByteBuffer.allocateDirect(64 * 1024)
core/src/main/scala/org/apache/spark/util/DirectByteBufferOutputStream.scala: val newBuffer = ByteBuffer.allocateDirect(newCapacity)
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 4, 2024
…yteBuffer.allocateDirect` This PR aims to use `Platform.allocateDirectBuffer` instead of `ByteBuffer.allocateDirect`. #47733 (review) Allocating off-heap memory should use the `allocateDirectBuffer` API provided `by Platform`. No GA No Closes #47987 from cxzl25/SPARK-49509. Authored-by: sychen <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 2ed6c3e) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Merged to master/3.5 for Apache Spark 3.5.3. |
turboFei
pushed a commit
to turboFei/spark
that referenced
this pull request
Nov 6, 2025
…yteBuffer.allocateDirect` (apache#557) This PR aims to use `Platform.allocateDirectBuffer` instead of `ByteBuffer.allocateDirect`. apache#47733 (review) Allocating off-heap memory should use the `allocateDirectBuffer` API provided `by Platform`. No GA No Closes apache#47987 from cxzl25/SPARK-49509. Authored-by: sychen <[email protected]> (cherry picked from commit 2ed6c3e) Signed-off-by: Dongjoon Hyun <[email protected]> Co-authored-by: sychen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to use
Platform.allocateDirectBufferinstead ofByteBuffer.allocateDirect.Why are the changes needed?
#47733 (review)
Allocating off-heap memory should use the
allocateDirectBufferAPI providedby Platform.Does this PR introduce any user-facing change?
No
How was this patch tested?
GA
Was this patch authored or co-authored using generative AI tooling?
No