-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-49494][DOCS] Use spark logos from spark-website in docs #47966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @dongjoon-hyun @cloud-fan @HyukjinKwon, thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering this is a safe way which is able to provide a recovery from the disaster, @yaooqinn .
For example, how can we recover our website when ASF Infra team lost the files at https://spark.apache.org/images/spark-logo-rev.svg ?
|
Thank you @dongjoon-hyun. I'm not using official logos in the infrastructure service of https://apache.org/logos since we have not fully uploaded all our logo variants to it. The https://spark.apache.org/images/spark-logo-rev.svg points to https://github.com/apache/spark-website/blob/asf-site/site/images/spark-logo-rev.svg which is a copy from https://github.com/apache/spark-website/blob/asf-site/images/spark-logo-rev.svg by jekyll build. I guess we handle these files ourselves. In this case, if the |
|
Maybe, I wasn't clear enough. What I meant was the case ASF website lost the disk and we need to republish our website cleanly. Let me rephrase my question more specifically. So, all deleted files of this PR are redundant ones because our
|
|
Yes, @dongjoon-hyun. The 'spark-website.git' has them |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
|
Merged to master! Thank you. |
… via Live GitHub Pages Updates ### What changes were proposed in this pull request? This pull request introduces functionalities that enable 'Document and Feature Preview on the master branch via Live GitHub Pages Updates'. ### Why are the changes needed? - Instead of limited 72-hour voting phases, it provides the developer community with more opportunities to preview and verify the documentation contents. - Instead of waiting for the final announcement of an official spark feature release, users can now preview some of the ongoing documented features, increasing the willingness to upgrade, sensing breaking changes in advance, and reducing the burden during the final upgrades. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? An [example](https://yaooqinn.github.io/spark-gh-pages/) has been established by this repo - https://github.com/yaooqinn/spark-gh-pages - Broken logo links are fixed at #47966 ### Was this patch authored or co-authored using generative AI tooling? no Closes #47968 from yaooqinn/SPARK-49495. Authored-by: Kent Yao <[email protected]> Signed-off-by: Kent Yao <[email protected]>
…h via Live GitHub Pages Updates
### What changes were proposed in this pull request?
This pull request introduces functionalities that enable 'Document and Feature Preview on the master branch via Live GitHub Pa
ges Updates'.
### Why are the changes needed?
- Instead of limited 72-hour voting phases, it provides the developer community with more opportunities to preview and verify
the documentation contents.
- Instead of waiting for the final announcement of an official spark feature release, users can now preview some of the ongoin
g documented features, increasing the willingness to upgrade, sensing breaking changes in advance, and reducing the burden during
the final upgrades.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
An [example](https://yaooqinn.github.io/spark-gh-pages/) has been established by this repo - https://github.com/yaooqinn/spark
-gh-pages
- Broken logo links are fixed at apache#47966
### Was this patch authored or co-authored using generative AI tooling?
no
What changes were proposed in this pull request?
Use spark logos from spark-website in docs and remove them from spark main repo
Why are the changes needed?
/img/spark-logo-rev.svgis invalidDoes this PR introduce any user-facing change?
no
How was this patch tested?
doc build, https://github.com/yaooqinn/spark/actions/runs/10676269598/artifacts/1884295142
Was this patch authored or co-authored using generative AI tooling?
no