[SPARK-49476][SQL] Fix nullability of base64 function #47941
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
MaxGekk
reviewed
Sep 1, 2024
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
LGTM except of a comment.
Please, append the [SQL] tag in PR's title.
Comment on lines
470
to
473
| assert(!Base64(Literal(bytes)).nullable) | ||
| assert(Base64(Literal.create(null, BinaryType)).nullable) | ||
| assert(!UnBase64(Literal("AQIDBA==")).nullable) | ||
| assert(UnBase64(Literal.create(null, StringType)).nullable) |
Member
There was a problem hiding this comment.
Let's add a check when you pass non-NULL expr but mark it as a nullable:
assert(Base64(Literal(bytes).castNullable()).nullable)
Kimahriman
changed the title
yaooqinn
approved these changes
Sep 2, 2024
LuciferYang
approved these changes
Sep 2, 2024
| assert(UnBase64(Literal.create(null, StringType)).nullable) | ||
| assert(UnBase64(Literal("AQIDBA==").castNullable()).nullable) | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
nit: Adding one blank line here is enough
MaxGekk
reviewed
Sep 2, 2024
...talyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
…essions/StringExpressionsSuite.scala
MaxGekk
approved these changes
Sep 2, 2024
Member
There was a problem hiding this comment.
+1, LGTM. Merging to master/3.5.
Thank you, @Kimahriman and @LuciferYang @yaooqinn for review.
MaxGekk
added a commit
that referenced
this pull request
Sep 2, 2024
### What changes were proposed in this pull request? Fix the nullability of the `Base64` expression to be based on the child's nullability, and not always be nullable. ### Why are the changes needed? #47303 had a side effect of changing the nullability by the switch to using `StaticInvoke`. This was also backported to Spark 3.5.2 and caused schema mismatch errors for stateful streams when we upgraded. This restores the previous behavior which is supported by StaticInvoke through the `returnNullable` argument. If the child is non-nullable, we know the result will be non-nullable. ### Does this PR introduce _any_ user-facing change? Restores the nullability of the `Base64` expression to what is was in Spark 3.5.1 and earlier. ### How was this patch tested? New UT ### Was this patch authored or co-authored using generative AI tooling? No Closes #47941 from Kimahriman/base64-nullability. Lead-authored-by: Adam Binford <[email protected]> Co-authored-by: Maxim Gekk <[email protected]> Signed-off-by: Max Gekk <[email protected]> (cherry picked from commit c274c5a) Signed-off-by: Max Gekk <[email protected]>
Contributor
Author
|
Made a follow up to fix a test in the 3.5 backport #47964 |
yaooqinn
pushed a commit
that referenced
this pull request
Sep 3, 2024
### What changes were proposed in this pull request? Fix a test that is failing from backporting #47941 ### Why are the changes needed? Fix test ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Fixed test ### Was this patch authored or co-authored using generative AI tooling? No Closes #47964 from Kimahriman/base64-proto-test. Authored-by: Adam Binford <[email protected]> Signed-off-by: Kent Yao <[email protected]>
Member
|
Thank you, @Kimahriman and all. |
turboFei
pushed a commit
to turboFei/spark
that referenced
this pull request
Nov 6, 2025
* [SPARK-49476][SQL] Fix nullability of base64 function ### What changes were proposed in this pull request? Fix the nullability of the `Base64` expression to be based on the child's nullability, and not always be nullable. ### Why are the changes needed? apache#47303 had a side effect of changing the nullability by the switch to using `StaticInvoke`. This was also backported to Spark 3.5.2 and caused schema mismatch errors for stateful streams when we upgraded. This restores the previous behavior which is supported by StaticInvoke through the `returnNullable` argument. If the child is non-nullable, we know the result will be non-nullable. ### Does this PR introduce _any_ user-facing change? Restores the nullability of the `Base64` expression to what is was in Spark 3.5.1 and earlier. ### How was this patch tested? New UT ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47941 from Kimahriman/base64-nullability. Lead-authored-by: Adam Binford <[email protected]> Co-authored-by: Maxim Gekk <[email protected]> Signed-off-by: Max Gekk <[email protected]> (cherry picked from commit c274c5a) Signed-off-by: Max Gekk <[email protected]> * [SPARK-49476][SQL][3.5][FOLLOWUP] Fix base64 proto test ### What changes were proposed in this pull request? Fix a test that is failing from backporting apache#47941 ### Why are the changes needed? Fix test ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Fixed test ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47964 from Kimahriman/base64-proto-test. Authored-by: Adam Binford <[email protected]> Signed-off-by: Kent Yao <[email protected]> * [SPARK-49476][SQL][3.5][FOLLOWUP] Fix base64 proto test ### What changes were proposed in this pull request? Fix a test that is failing from backporting apache#47941 ### Why are the changes needed? Fix test ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Fixed test ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47964 from Kimahriman/base64-proto-test. Authored-by: Adam Binford <[email protected]> Signed-off-by: Kent Yao <[email protected]> --------- Signed-off-by: Max Gekk <[email protected]> Signed-off-by: Kent Yao <[email protected]> Co-authored-by: Adam Binford <[email protected]> Co-authored-by: Maxim Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the nullability of the
Base64expression to be based on the child's nullability, and not always be nullable.Why are the changes needed?
#47303 had a side effect of changing the nullability by the switch to using
StaticInvoke. This was also backported to Spark 3.5.2 and caused schema mismatch errors for stateful streams when we upgraded. This restores the previous behavior which is supported by StaticInvoke through thereturnNullableargument. If the child is non-nullable, we know the result will be non-nullable.Does this PR introduce any user-facing change?
Restores the nullability of the
Base64expression to what is was in Spark 3.5.1 and earlier.How was this patch tested?
New UT
Was this patch authored or co-authored using generative AI tooling?
No