[SPARK-43242][CORE][3.5] Fix throw 'Unexpected type of BlockId' in shuffle corruption diagnose #47910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' in shuffle corruption diagnose A minor bugfix in `ShuffleBlockFetcherIterator.diagnose`, which not handle type ShuffleBlockBatchId properly `.diagnose()` is used in exception handling try-catch block, throw new exception due to type mismatch (in this case, `ShuffleBlockBatchId`) will swallow original exception stack No Existing tests Closes apache#40921 from CavemanIV/SPARK-43242. Lead-authored-by: zhangliang <[email protected]> Co-authored-by: sychen <[email protected]> Signed-off-by: Yi Wu <[email protected]>
CavemanIV
changed the title
Ngone51
approved these changes
Aug 30, 2024
Ngone51
pushed a commit
that referenced
this pull request
Aug 30, 2024
…uffle corruption diagnose #### What changes were proposed in this pull request? port to 3.5 for [[SPARK-43242](https://issues.apache.org/jira/browse/SPARK-43242)][CORE] Fix throw 'Unexpected type of BlockId' in shuffle corruption diagnose #### Why are the changes needed? 3.5 conflict with PR in master, see end of discussion #40921 #### Does this PR introduce any user-facing change? No #### How was this patch tested? Existing tests Closes #47910 from CavemanIV/port3.5-SPARK-43242. Authored-by: zhangliang <[email protected]> Signed-off-by: Yi Wu <[email protected]>
Member
|
Thanks, merged to branch-3.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
port to 3.5 for [SPARK-43242][CORE] Fix throw 'Unexpected type of BlockId' in shuffle corruption diagnose
Why are the changes needed?
3.5 conflict with PR in master, see end of discussion #40921
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests