[SPARK-49402][PYTHON] Fix Binder integration in PySpark documentation #47883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinrong-meng
approved these changes
Aug 27, 2024
yaooqinn
approved these changes
Aug 27, 2024
Member
Author
|
Thanks all! Merged to master, branch-3.5 and branch-3.4. |
HyukjinKwon
added a commit
that referenced
this pull request
Aug 27, 2024
This PR proposes to fix Binder integration by using `Dockerfile` directly. Binder integration is broken now (https://mybinder.org/v2/gh/apache/spark/bb7846dd487?filepath=python%2Fdocs%2Fsource%2Fgetting_started%2Fquickstart_df.ipynb):  This seems to be related to the size of the repository (jupyterhub/mybinder.org-deploy#3074). I tried all the ways out but could not find the way except using `Dockerfile`. Yes. This should recover the Binder integration. Manually tested within my fork: https://mybinder.org/v2/gh/HyukjinKwon/spark/binder-test1?filepath=python%2Fdocs%2Fsource%2Fgetting_started%2Fquickstart_df.ipynb No. Closes #47883 from HyukjinKwon/binder-test1. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 9fc1e05) Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon
added a commit
that referenced
this pull request
Aug 27, 2024
This PR proposes to fix Binder integration by using `Dockerfile` directly. Binder integration is broken now (https://mybinder.org/v2/gh/apache/spark/bb7846dd487?filepath=python%2Fdocs%2Fsource%2Fgetting_started%2Fquickstart_df.ipynb):  This seems to be related to the size of the repository (jupyterhub/mybinder.org-deploy#3074). I tried all the ways out but could not find the way except using `Dockerfile`. Yes. This should recover the Binder integration. Manually tested within my fork: https://mybinder.org/v2/gh/HyukjinKwon/spark/binder-test1?filepath=python%2Fdocs%2Fsource%2Fgetting_started%2Fquickstart_df.ipynb No. Closes #47883 from HyukjinKwon/binder-test1. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 9fc1e05) Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon
added a commit
that referenced
this pull request
Aug 28, 2024
…nnect notebook ### What changes were proposed in this pull request? This is a followup of #47883 that adds manual `source ~/.profile`. ### Why are the changes needed? Ever since we switched to `Dockerfile`, none of `./profile`, `/.bashrc`, `./bash_profile`, etc seems working. There are a couple of related issues in Jupyter but I cannot figure it out. This is the only cell it needs the environment variable so decided to simply work around. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually tested. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #47902 from HyukjinKwon/SPARK-49402-followup. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon
added a commit
that referenced
this pull request
Aug 28, 2024
…nnect notebook This is a followup of #47883 that adds manual `source ~/.profile`. Ever since we switched to `Dockerfile`, none of `./profile`, `/.bashrc`, `./bash_profile`, etc seems working. There are a couple of related issues in Jupyter but I cannot figure it out. This is the only cell it needs the environment variable so decided to simply work around. No. Manually tested. No. Closes #47902 from HyukjinKwon/SPARK-49402-followup. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 1c9cde5) Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon
added a commit
that referenced
this pull request
Aug 28, 2024
…nnect notebook This is a followup of #47883 that adds manual `source ~/.profile`. Ever since we switched to `Dockerfile`, none of `./profile`, `/.bashrc`, `./bash_profile`, etc seems working. There are a couple of related issues in Jupyter but I cannot figure it out. This is the only cell it needs the environment variable so decided to simply work around. No. Manually tested. No. Closes #47902 from HyukjinKwon/SPARK-49402-followup. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 1c9cde5) Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit df07aa7) Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to fix Binder integration by using
Dockerfiledirectly.Why are the changes needed?
Binder integration is broken now (https://mybinder.org/v2/gh/apache/spark/bb7846dd487?filepath=python%2Fdocs%2Fsource%2Fgetting_started%2Fquickstart_df.ipynb):
This seems to be related to the size of the repository (jupyterhub/mybinder.org-deploy#3074).
I tried all the ways out but could not find the way except using
Dockerfile.Does this PR introduce any user-facing change?
Yes. This should recover the Binder integration.
How was this patch tested?
Manually tested within my fork:
https://mybinder.org/v2/gh/HyukjinKwon/spark/binder-test1?filepath=python%2Fdocs%2Fsource%2Fgetting_started%2Fquickstart_df.ipynb
Was this patch authored or co-authored using generative AI tooling?
No.