Skip to content

[SPARK-6018] [YARN] NoSuchMethodError in Spark app is swallowed by YARN AM #4773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
piaozhexiu wants to merge 3 commits into from
Closed

[SPARK-6018] [YARN] NoSuchMethodError in Spark app is swallowed by YARN AM #4773

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb5750d
NoSuchMethodError in Spark app is swallowed by YARN AM
Feb 25, 2015
1e71d2d
Replace placeholder with throwable
Feb 25, 2015
2a919d5
Rename e with cause to avoid duplicate names
Feb 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,14 +483,14 @@ private[spark] class ApplicationMaster(
} catch {
case e: InvocationTargetException =>
e.getCause match {
case _: InterruptedException =>
case e: InterruptedException =>
Copy link
Member

@srowen srowen Feb 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: reusing the name e is ambiguous but also unnecessary; this can be _ too? (Yes the second clause will generate a warning without : Throwable

// Reporter thread can interrupt to stop user class
case e: Exception =>
case _ =>
Copy link
Contributor

@vanzin vanzin Feb 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the problem is that this was not catching Error, but just Exception, right?

I think this generates a compiler warning, so probably should be case _: Throwable =>. And you can avoid the duplicate getCause calls by giving this variable a name instead of using the placeholder.

finish(FinalApplicationStatus.FAILED,
ApplicationMaster.EXIT_EXCEPTION_USER_CLASS,
"User class threw exception: " + e.getMessage)
"User class threw exception: " + e.getCause.getMessage)
// re-throw to get it logged
throw e
throw e.getCause
}
}
}
Expand Down